Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1116)

Issue 2346863003: PrerenderManager: No longer expose weak pointers. (Closed)

Created:
4 years, 3 months ago by mmenke
Modified:
4 years, 3 months ago
Reviewers:
eroman, davidben
CC:
chromium-reviews, tburkard+watch_chromium.org, gavinp+prer_chromium.org, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

PrerenderManager: No longer expose weak pointers. BUG=none Committed: https://crrev.com/bd46b80521dbc8132e9f2a5297dc71b46f55b0c1 Cr-Commit-Position: refs/heads/master@{#419341}

Patch Set 1 #

Patch Set 2 : Oops #

Patch Set 3 : Fix net-internals #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -17 lines) Patch
M chrome/browser/prerender/prerender_manager.h View 1 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/prerender/prerender_manager.cc View 1 2 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/net_internals/net_internals_ui.cc View 1 2 3 chunks +6 lines, -12 lines 0 comments Download

Messages

Total messages: 29 (16 generated)
mmenke
pasko: Please review prerender eroman: Please review net_internals (Note that other calls from Javascript use ...
4 years, 3 months ago (2016-09-15 19:36:01 UTC) #10
mmenke
Oops, pasko's OOO. [+davidben]: Mind reviewing a prerender CL? It's a pretty trivial CL.
4 years, 3 months ago (2016-09-16 17:19:27 UTC) #12
davidben
lgtm
4 years, 3 months ago (2016-09-16 17:26:19 UTC) #13
eroman
lgtm
4 years, 3 months ago (2016-09-16 22:55:38 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2346863003/40001
4 years, 3 months ago (2016-09-16 22:59:06 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_compile_dbg_ng/builds/264707) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 3 months ago (2016-09-16 23:02:58 UTC) #18
mmenke
Bots are borked. :(
4 years, 3 months ago (2016-09-16 23:11:29 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2346863003/40001
4 years, 3 months ago (2016-09-16 23:12:13 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_compile_dbg/builds/130658) android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, ...
4 years, 3 months ago (2016-09-16 23:16:30 UTC) #23
Dirk Pranke
On 2016/09/16 23:12:13, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
4 years, 3 months ago (2016-09-16 23:17:29 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2346863003/40001
4 years, 3 months ago (2016-09-16 23:19:51 UTC) #26
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-17 00:17:11 UTC) #27
commit-bot: I haz the power
4 years, 3 months ago (2016-09-17 00:20:35 UTC) #29
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/bd46b80521dbc8132e9f2a5297dc71b46f55b0c1
Cr-Commit-Position: refs/heads/master@{#419341}

Powered by Google App Engine
This is Rietveld 408576698