Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Unified Diff: chrome/browser/prerender/prerender_manager.cc

Issue 2346863003: PrerenderManager: No longer expose weak pointers. (Closed)
Patch Set: Fix net-internals Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/prerender/prerender_manager.cc
diff --git a/chrome/browser/prerender/prerender_manager.cc b/chrome/browser/prerender/prerender_manager.cc
index 682968aeb11883507ebc21aaf7813ed1d51acadb..10887f9b63b0f5129c56d99a44eed3dfc98d06c1 100644
--- a/chrome/browser/prerender/prerender_manager.cc
+++ b/chrome/browser/prerender/prerender_manager.cc
@@ -157,12 +157,14 @@ struct PrerenderManager::NavigationRecord {
PrerenderManager::PrerenderManager(Profile* profile)
: profile_(profile),
prerender_contents_factory_(PrerenderContents::CreateFactory()),
- last_prerender_start_time_(GetCurrentTimeTicks() -
+ last_prerender_start_time_(
+ GetCurrentTimeTicks() -
base::TimeDelta::FromMilliseconds(kMinTimeBetweenPrerendersMs)),
prerender_history_(new PrerenderHistory(kHistoryLength)),
histograms_(new PrerenderHistograms()),
profile_network_bytes_(0),
- last_recorded_profile_network_bytes_(0) {
+ last_recorded_profile_network_bytes_(0),
+ weak_factory_(this) {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
// Certain experiments override our default config_ values.
@@ -1032,7 +1034,8 @@ void PrerenderManager::PeriodicCleanup() {
void PrerenderManager::PostCleanupTask() {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
base::ThreadTaskRunnerHandle::Get()->PostTask(
- FROM_HERE, base::Bind(&PrerenderManager::PeriodicCleanup, AsWeakPtr()));
+ FROM_HERE, base::Bind(&PrerenderManager::PeriodicCleanup,
+ weak_factory_.GetWeakPtr()));
}
base::TimeTicks PrerenderManager::GetExpiryTimeForNewPrerender(
« no previous file with comments | « chrome/browser/prerender/prerender_manager.h ('k') | chrome/browser/ui/webui/net_internals/net_internals_ui.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698