Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 2346813002: Add histograms for script execution time for doc write observer (Closed)

Created:
4 years, 3 months ago by Bryan McQuade
Modified:
4 years, 3 months ago
CC:
asvitkine+watch_chromium.org, chromium-reviews, csharrison+watch_chromium.org, loading-reviews+metrics_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add histograms for script execution time for doc write observer There has been a desire to better understand the breakdown of performance impact as a result of the doc.write intervention. We currently track script load time duration for the intervention. This change allows us to also track script execution time duration for the intervention. BUG=640260 Committed: https://crrev.com/612a4b664c1589e12d2d12e35044c68224c63851 Cr-Commit-Position: refs/heads/master@{#419557}

Patch Set 1 #

Total comments: 7

Patch Set 2 : address histograms.xml comments #

Patch Set 3 : move affected histograms to clients block #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -54 lines) Patch
M chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.cc View 4 chunks +40 lines, -10 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 6 chunks +47 lines, -44 lines 0 comments Download

Messages

Total messages: 31 (19 generated)
Bryan McQuade
csharrison, PTAL for metrics change rkaplow, PTAL for histograms.xml
4 years, 3 months ago (2016-09-15 14:58:15 UTC) #6
rkaplow
4 years, 3 months ago (2016-09-15 14:59:29 UTC) #8
Charlie Harrison
lgtm https://codereview.chromium.org/2346813002/diff/1/chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.cc File chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.cc (right): https://codereview.chromium.org/2346813002/diff/1/chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.cc#newcode130 chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.cc:130: "ParseBlockedOnScriptExecutionFromDocumentWrite"; Have we dug ourselves into a hole ...
4 years, 3 months ago (2016-09-15 15:28:59 UTC) #9
Bryan McQuade
Thanks! https://codereview.chromium.org/2346813002/diff/1/chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.cc File chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.cc (right): https://codereview.chromium.org/2346813002/diff/1/chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.cc#newcode130 chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.cc:130: "ParseBlockedOnScriptExecutionFromDocumentWrite"; On 2016/09/15 at 15:28:59, Charlie Harrison wrote: ...
4 years, 3 months ago (2016-09-15 15:44:24 UTC) #10
gayane -on leave until 09-2017
https://codereview.chromium.org/2346813002/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/2346813002/diff/1/tools/metrics/histograms/histograms.xml#oldcode103253 tools/metrics/histograms/histograms.xml:103253: name="PageLoad.Clients.DocWrite.Block.Timing2.ParseDuration"/> Can the suffix name="Background" on line 104030 go ...
4 years, 3 months ago (2016-09-16 16:59:44 UTC) #13
Bryan McQuade
Thanks for the review! PTAL. https://codereview.chromium.org/2346813002/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/2346813002/diff/1/tools/metrics/histograms/histograms.xml#oldcode103253 tools/metrics/histograms/histograms.xml:103253: name="PageLoad.Clients.DocWrite.Block.Timing2.ParseDuration"/> On 2016/09/16 at ...
4 years, 3 months ago (2016-09-19 15:11:51 UTC) #18
gayane -on leave until 09-2017
lgtm
4 years, 3 months ago (2016-09-19 20:06:38 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2346813002/40001
4 years, 3 months ago (2016-09-19 20:42:57 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/262319)
4 years, 3 months ago (2016-09-19 20:53:09 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2346813002/40001
4 years, 3 months ago (2016-09-19 21:17:03 UTC) #28
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-19 21:31:34 UTC) #29
commit-bot: I haz the power
4 years, 3 months ago (2016-09-19 21:34:06 UTC) #31
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/612a4b664c1589e12d2d12e35044c68224c63851
Cr-Commit-Position: refs/heads/master@{#419557}

Powered by Google App Engine
This is Rietveld 408576698