Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2528)

Unified Diff: chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.cc

Issue 2346813002: Add histograms for script execution time for doc write observer (Closed)
Patch Set: move affected histograms to clients block Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.cc
diff --git a/chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.cc b/chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.cc
index 5a8ce3b903762f6bf06f7186cf674b05ded3b7ae..9083e29271eb1b8425b396bdf6462ab366d50bb4 100644
--- a/chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.cc
+++ b/chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.cc
@@ -84,18 +84,25 @@ const char kHistogramDocWriteParseStartToFirstContentfulPaintImmediate[] =
"ParseStartToFirstContentfulPaint";
const char kHistogramDocWriteParseDurationImmediate[] =
"PageLoad.Clients.DocWrite.Evaluator.ParseTiming.ParseDuration";
-const char kHistogramDocWriteParseBlockedOnScriptImmediate[] =
+const char kHistogramDocWriteParseBlockedOnScriptLoadImmediate[] =
"PageLoad.Clients.DocWrite.Evaluator.ParseTiming.ParseBlockedOnScriptLoad";
const char kHistogramDocWriteParseBlockedOnScriptLoadDocumentWriteImmediate[] =
"PageLoad.Clients.DocWrite.Evaluator.ParseTiming."
"ParseBlockedOnScriptLoadFromDocumentWrite";
+const char kHistogramDocWriteParseBlockedOnScriptExecutionImmediate[] =
+ "PageLoad.Clients.DocWrite.Evaluator.ParseTiming."
+ "ParseBlockedOnScriptExecution";
+const char
+ kHistogramDocWriteParseBlockedOnScriptExecutionDocumentWriteImmediate[] =
+ "PageLoad.Clients.DocWrite.Evaluator.ParseTiming."
+ "ParseBlockedOnScriptExecutionFromDocumentWrite";
const char kBackgroundHistogramDocWriteFirstContentfulPaintImmediate[] =
"PageLoad.Clients.DocWrite.Evaluator.PaintTiming."
"NavigationToFirstContentfulPaint."
"Background";
const char kBackgroundHistogramDocWriteParseDurationImmediate[] =
"PageLoad.Clients.DocWrite.Evaluator.ParseTiming.ParseDuration.Background";
-const char kBackgroundHistogramDocWriteParseBlockedOnScriptImmediate[] =
+const char kBackgroundHistogramDocWriteParseBlockedOnScriptLoadImmediate[] =
"PageLoad.Clients.DocWrite.Evaluator.ParseTiming.ParseBlockedOnScriptLoad."
"Background";
const char
@@ -109,18 +116,25 @@ const char kHistogramDocWriteBlockFirstContentfulPaintImmediate[] =
const char kHistogramDocWriteBlockParseStartToFirstContentfulPaintImmediate[] =
"PageLoad.Clients.DocWrite.Block.PaintTiming."
"ParseStartToFirstContentfulPaint";
-const char kHistogramDocWriteBlockParseBlockedOnScriptImmediate[] =
+const char kHistogramDocWriteBlockParseBlockedOnScriptLoadImmediate[] =
"PageLoad.Clients.DocWrite.Block.ParseTiming.ParseBlockedOnScriptLoad";
const char
kHistogramDocWriteBlockParseBlockedOnScriptLoadDocumentWriteImmediate[] =
"PageLoad.Clients.DocWrite.Block.ParseTiming."
"ParseBlockedOnScriptLoadFromDocumentWrite";
+const char kHistogramDocWriteBlockParseBlockedOnScriptExecutionImmediate[] =
+ "PageLoad.Clients.DocWrite.Block.ParseTiming.ParseBlockedOnScriptExecution";
+const char
+ kHistogramDocWriteBlockParseBlockedOnScriptExecutionDocumentWriteImmediate
+ [] = "PageLoad.Clients.DocWrite.Block.ParseTiming."
+ "ParseBlockedOnScriptExecutionFromDocumentWrite";
const char kHistogramDocWriteBlockParseDurationImmediate[] =
"PageLoad.Clients.DocWrite.Block.ParseTiming.ParseDuration";
-const char kBackgroundHistogramDocWriteBlockParseBlockedOnScriptImmediate[] =
- "PageLoad.Clients.DocWrite.Block.ParseTiming.ParseBlockedOnScriptLoad."
- "Background";
+const char
+ kBackgroundHistogramDocWriteBlockParseBlockedOnScriptLoadImmediate[] =
+ "PageLoad.Clients.DocWrite.Block.ParseTiming.ParseBlockedOnScriptLoad."
+ "Background";
const char
kBackgroundDocWriteBlockParseBlockedOnScriptLoadDocumentWriteImmediate[] =
"PageLoad.Clients.DocWrite.Block.ParseTiming."
@@ -262,19 +276,27 @@ void DocumentWritePageLoadMetricsObserver::LogDocumentWriteEvaluatorParseStop(
PAGE_LOAD_HISTOGRAM(internal::kHistogramDocWriteParseDurationImmediate,
parse_duration);
PAGE_LOAD_HISTOGRAM(
- internal::kHistogramDocWriteParseBlockedOnScriptImmediate,
+ internal::kHistogramDocWriteParseBlockedOnScriptLoadImmediate,
timing.parse_blocked_on_script_load_duration.value());
PAGE_LOAD_HISTOGRAM(
internal::
kHistogramDocWriteParseBlockedOnScriptLoadDocumentWriteImmediate,
timing.parse_blocked_on_script_load_from_document_write_duration
.value());
+ PAGE_LOAD_HISTOGRAM(
+ internal::kHistogramDocWriteParseBlockedOnScriptExecutionImmediate,
+ timing.parse_blocked_on_script_execution_duration.value());
+ PAGE_LOAD_HISTOGRAM(
+ internal::
+ kHistogramDocWriteParseBlockedOnScriptExecutionDocumentWriteImmediate,
+ timing.parse_blocked_on_script_execution_from_document_write_duration
+ .value());
} else {
PAGE_LOAD_HISTOGRAM(
internal::kBackgroundHistogramDocWriteParseDurationImmediate,
parse_duration);
PAGE_LOAD_HISTOGRAM(
- internal::kBackgroundHistogramDocWriteParseBlockedOnScriptImmediate,
+ internal::kBackgroundHistogramDocWriteParseBlockedOnScriptLoadImmediate,
timing.parse_blocked_on_script_load_duration.value());
PAGE_LOAD_HISTOGRAM(
internal::
@@ -379,20 +401,28 @@ void DocumentWritePageLoadMetricsObserver::LogDocumentWriteBlockParseStop(
PAGE_LOAD_HISTOGRAM(internal::kHistogramDocWriteBlockParseDurationImmediate,
parse_duration);
PAGE_LOAD_HISTOGRAM(
- internal::kHistogramDocWriteBlockParseBlockedOnScriptImmediate,
+ internal::kHistogramDocWriteBlockParseBlockedOnScriptLoadImmediate,
timing.parse_blocked_on_script_load_duration.value());
PAGE_LOAD_HISTOGRAM(
internal::
kHistogramDocWriteBlockParseBlockedOnScriptLoadDocumentWriteImmediate,
timing.parse_blocked_on_script_load_from_document_write_duration
.value());
+ PAGE_LOAD_HISTOGRAM(
+ internal::kHistogramDocWriteBlockParseBlockedOnScriptExecutionImmediate,
+ timing.parse_blocked_on_script_execution_duration.value());
+ PAGE_LOAD_HISTOGRAM(
+ internal::
+ kHistogramDocWriteBlockParseBlockedOnScriptExecutionDocumentWriteImmediate,
+ timing.parse_blocked_on_script_execution_from_document_write_duration
+ .value());
} else {
PAGE_LOAD_HISTOGRAM(
internal::kBackgroundHistogramDocWriteBlockParseDurationImmediate,
parse_duration);
PAGE_LOAD_HISTOGRAM(
internal::
- kBackgroundHistogramDocWriteBlockParseBlockedOnScriptImmediate,
+ kBackgroundHistogramDocWriteBlockParseBlockedOnScriptLoadImmediate,
timing.parse_blocked_on_script_load_duration.value());
PAGE_LOAD_HISTOGRAM(
internal::
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698