Have Range constructor take a Document reference in argument

Have Range constructor take a Document reference in argument

Have Range constructor take a Document reference in argument instead of
a pointer as the Document is expected to be non-null. Most callers
already have a reference so this avoids having to convert it into a
pointer.

Also update Range's ownerDocument() to return a reference as it can
never return NULL.

BUG=281400
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157165

[do-not-use, 2013-09-03 15:43:22]

https://codereview.chromium.org/23467007/diff/1/Source/core/dom/Range.h
File Source/core/dom/Range.h (right):

https://codereview.chromium.org/23467007/diff/1/Source/core/dom/Range.h#newco...
Source/core/dom/Range.h:171: RefPtr<Document> m_ownerDocument; // Cannot be
null.
BTW, a Reference-flavoured smart pointer class would be really useful here. It
would take care of ref'ing / unref'ing, while making it obvious that the value
cannot be NULL.

The code would look like:
Ref<Document> m_ownerDocument;
m_document.get() would return a (const) reference.
Such code would not compile: if (m_ownerDocument) { ... }

WebKit has recently added such class in WTF:
https://bugs.webkit.org/show_bug.cgi?id=120570

I would propose to port that WebKit patch in a follow-up to improve this. Please
let me know if you agree.

[abarth-chromium, 2013-09-03 21:02:01]

On 2013/09/03 15:43:22, Christophe Dumez wrote:
> I would propose to port that WebKit patch in a follow-up to improve this.
Please
> let me know if you agree.

Sounds like a good idea.

[abarth-chromium, 2013-09-03 21:05:21]

lgtm

[commit-bot: I haz the power, 2013-09-03 21:05:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/23467007/1

[commit-bot: I haz the power, 2013-09-03 22:52:31]

Change committed as 157165