Source/core/editing/VisiblePosition.cpp - Issue 23467007: Have Range constructor take a Document reference in argument

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/VisiblePosition.cpp

Issue 23467007: Have Range constructor take a Document reference in argument (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/editing/VisiblePosition.cpp

diff --git a/Source/core/editing/VisiblePosition.cpp b/Source/core/editing/VisiblePosition.cpp

index 685bdf86ba8df429014acea12ee22fad5cf166d7..00dda8dea9cd59b332a7f09fb5681d51cfab22cf 100644

--- a/Source/core/editing/VisiblePosition.cpp

+++ b/Source/core/editing/VisiblePosition.cpp

@@ -680,7 +680,7 @@ PassRefPtr<Range> makeRange(const VisiblePosition &start, const VisiblePosition

if (s.isNull() || e.isNull())

return 0;

- return Range::create(&s.containerNode()->document(), s.containerNode(), s.offsetInContainerNode(), e.containerNode(), e.offsetInContainerNode());

+ return Range::create(s.containerNode()->document(), s.containerNode(), s.offsetInContainerNode(), e.containerNode(), e.offsetInContainerNode());

}

VisiblePosition startVisiblePosition(const Range *r, EAffinity affinity)