[BlobStorage] Adding error code translations for cache storage metadata.

[BlobStorage] Adding error code translations for cache storage metadata.

BUG=631262
Committed: https://crrev.com/9f16719bc8a0db5a53c0afa4ddab23ca594befc8
Cr-Commit-Position: refs/heads/master@{#418712}

[dmurph, 2016-09-14 21:56:35]

dmurph@chromium.org changed reviewers:
+ jsbell@chromium.org, pwnall@chromium.org

[dmurph, 2016-09-14 21:56:36]

Easy review for you guys, just adding more error code translations. Apparently
this isn't a normal thing, I wish we had a utility in the codebase to do this :/
:(

[dmurph, 2016-09-14 21:59:57]

The CQ bit was checked by dmurph@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-14 22:00:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jsbell, 2016-09-14 22:03:13]

lgtm - I'm not sure the particular errors matter, so this is fine.

https://codereview.chromium.org/2346623002/diff/20001/storage/browser/blob/bl...
File storage/browser/blob/blob_url_request_job.cc (right):

https://codereview.chromium.org/2346623002/diff/20001/storage/browser/blob/bl...
storage/browser/blob/blob_url_request_job.cc:257: case
net::ERR_CACHE_CHECKSUM_READ_FAILURE:
Maybe this (these?) should be HTTP_INTERNAL_SERVER_ERROR?

[dmurph, 2016-09-14 22:07:19]

https://codereview.chromium.org/2346623002/diff/20001/storage/browser/blob/bl...
File storage/browser/blob/blob_url_request_job.cc (right):

https://codereview.chromium.org/2346623002/diff/20001/storage/browser/blob/bl...
storage/browser/blob/blob_url_request_job.cc:257: case
net::ERR_CACHE_CHECKSUM_READ_FAILURE:
On 2016/09/14 22:03:13, jsbell wrote:
> Maybe this (these?) should be HTTP_INTERNAL_SERVER_ERROR?
> 

Sure, not really picky here, just don't want to DCHECK.

[dmurph, 2016-09-14 22:07:37]

Description was changed from

==========
[BlobStorage] Adding error code translations for cache storage metadata.

BUG=636269
==========

to

==========
[BlobStorage] Adding error code translations for cache storage metadata.

BUG=631262
==========

[dmurph, 2016-09-14 22:07:59]

The CQ bit was checked by dmurph@chromium.org

[dmurph, 2016-09-14 22:07:59]

The patchset sent to the CQ was uploaded after l-g-t-m from jsbell@chromium.org
Link to the patchset: https://codereview.chromium.org/2346623002/#ps40001
(title: "moved to internal server error")

[commit-bot: I haz the power, 2016-09-14 22:08:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 23:06:45]

Description was changed from

==========
[BlobStorage] Adding error code translations for cache storage metadata.

BUG=631262
==========

to

==========
[BlobStorage] Adding error code translations for cache storage metadata.

BUG=631262
==========

[commit-bot: I haz the power, 2016-09-14 23:06:46]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-14 23:10:34]

Description was changed from

==========
[BlobStorage] Adding error code translations for cache storage metadata.

BUG=631262
==========

to

==========
[BlobStorage] Adding error code translations for cache storage metadata.

BUG=631262

Committed: https://crrev.com/9f16719bc8a0db5a53c0afa4ddab23ca594befc8
Cr-Commit-Position: refs/heads/master@{#418712}
==========

[commit-bot: I haz the power, 2016-09-14 23:10:35]

Patchset 3 (id:??) landed as
https://crrev.com/9f16719bc8a0db5a53c0afa4ddab23ca594befc8
Cr-Commit-Position: refs/heads/master@{#418712}