[BlobStorage] Adding error code translations for cache storage metadata.

storage/browser/blob/blob_url_request_job.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "storage/browser/blob/blob_url_request_job.h"
 
 #include <stdint.h>
 
 #include <algorithm>
 #include <limits>
@@ skipping 235 matching lines @@
   // If we already return the headers on success, we can't change the headers
   // now. Instead, we just error out.
   DCHECK(!response_info_) << "Cannot NotifyFailure after headers.";
 
   net::HttpStatusCode status_code = net::HTTP_INTERNAL_SERVER_ERROR;
   switch (error_code) {
     case net::ERR_ACCESS_DENIED:
       status_code = net::HTTP_FORBIDDEN;
       break;
     case net::ERR_FILE_NOT_FOUND:
+    case net::ERR_CACHE_READ_FAILURE:
+    case net::ERR_CACHE_CHECKSUM_READ_FAILURE:

[jsbell, 2016/09/14 22:03:13]

Maybe this (these?) should be HTTP_INTERNAL_SERVER_ERROR?

[dmurph, 2016/09/14 22:07:19]

Sure, not really picky here, just don't want to DCHECK.

       status_code = net::HTTP_NOT_FOUND;
       break;
     case net::ERR_METHOD_NOT_SUPPORTED:
       status_code = net::HTTP_METHOD_NOT_ALLOWED;
       break;
     case net::ERR_REQUEST_RANGE_NOT_SATISFIABLE:
       status_code = net::HTTP_REQUESTED_RANGE_NOT_SATISFIABLE;
       break;
+    case net::ERR_INVALID_ARGUMENT:
+      status_code = net::HTTP_BAD_REQUEST;
+      break;
+    case net::ERR_UNEXPECTED:
     case net::ERR_FAILED:
       break;
     default:
-      DCHECK(false);
+      DCHECK(false) << "Error code not supported: " << error_code;
       break;
   }
   HeadersCompleted(status_code);
 }
 
 void BlobURLRequestJob::HeadersCompleted(net::HttpStatusCode status_code) {
   std::string status("HTTP/1.1 ");
   status.append(base::IntToString(status_code));
   status.append(" ");
   status.append(net::GetHttpReasonPhrase(status_code));
@@ skipping 37 matching lines @@
 
   response_info_.reset(new net::HttpResponseInfo());
   response_info_->headers = headers;
   if (blob_reader_)
     response_info_->metadata = blob_reader_->side_data();
 
   NotifyHeadersComplete();
 }
 
 }  // namespace storage