Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(895)

Issue 2346433002: Ozone caca: Fix segfault during GPU initialization (Closed)

Created:
4 years, 3 months ago by fwang
Modified:
4 years, 3 months ago
Reviewers:
rjkroege
CC:
chromium-reviews, kalyank, ozone-reviews_chromium.org, not to use - tonikitoo
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ozone caca: Fix segfault during GPU initialization After https://codereview.chromium.org/2270463002, gl::init::GetAllowedGLImplementations assumes GetSurfaceFactoryOzone to be non-null on the GPU side. The remaining Ozone platform violating this assumption is addressed in this CL. BUG=640613 R=rjkroege@chromium.org Committed: https://crrev.com/380aafbf57e5b6a162502065220e05beb391e287 Cr-Commit-Position: refs/heads/master@{#418781}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M ui/ozone/platform/caca/ozone_platform_caca.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
rjkroege
lgtm
4 years, 3 months ago (2016-09-15 00:54:57 UTC) #2
rjkroege
lgtm
4 years, 3 months ago (2016-09-15 00:55:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2346433002/1
4 years, 3 months ago (2016-09-15 03:59:24 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-15 04:36:05 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 04:38:16 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/380aafbf57e5b6a162502065220e05beb391e287
Cr-Commit-Position: refs/heads/master@{#418781}

Powered by Google App Engine
This is Rietveld 408576698