Change _ITERATOR_DEBUG_LEVEL to 1 on Release builds

Change _ITERATOR_DEBUG_LEVEL to 1 on Release builds

VS2010 changed the default to 0 meaning weaker checks in our
release builds.  This commit changes it back again.

BUG=289691
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=229222

[Will Harris, 2013-09-18 18:49:19]

Hi Scott, the bug as all the juicy details on this change.  We should probably
do some perf tests afterwards to check the impact.

[scottmg, 2013-09-18 19:03:43]

On 2013/09/18 18:49:19, Will Harris wrote:
> Hi Scott, the bug as all the juicy details on this change.  We should probably
> do some perf tests afterwards to check the impact.

Could we do some perf tests beforehand instead?

In any case, there's a lot of gnashing of teeth over Aura and gpu features going
on and off for M31 due to perf regressions, so please don't land this until
after M31 is fully branched.

ISTR someone hacking vector iterators in... libvpx? ffmpeg? recently, I wonder
if this is too global of a change since it'll affect all third_party too.

[scottmg, 2013-09-18 19:03:49]

https://codereview.chromium.org/23464081/diff/1/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/23464081/diff/1/build/common.gypi#newcode2679
build/common.gypi:2679: ['win_debug_disable_iterator_debugging!=1', {
is this used elsewhere? it really shouldn't be called win_"debug" if it's
affecting the release config.

[Will Harris, 2013-09-18 19:13:40]

On 2013/09/18 19:03:49, scottmg wrote:
> https://codereview.chromium.org/23464081/diff/1/build/common.gypi
> File build/common.gypi (right):
> 
> https://codereview.chromium.org/23464081/diff/1/build/common.gypi#newcode2679
> build/common.gypi:2679: ['win_debug_disable_iterator_debugging!=1', {
> is this used elsewhere? it really shouldn't be called win_"debug" if it's
> affecting the release config.

this flag is set when using tsan or drmemory, but you're right that since
it's setting a release only flag I should probably add a new
win_release_disable_iterator_debugging flag and set/check that in this case

[Will Harris, 2013-09-19 09:40:57]

https://codereview.chromium.org/23464081/diff/1/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/23464081/diff/1/build/common.gypi#newcode2679
build/common.gypi:2679: ['win_debug_disable_iterator_debugging!=1', {
On 2013/09/18 19:03:49, scottmg wrote:
> is this used elsewhere? it really shouldn't be called win_"debug" if it's
> affecting the release config.

added a new win_release_disable_iterator_debugging

it's not used anywhere else. it's just for the tsan/drmemory builds

[scottmg, 2013-09-19 23:15:55]

lgtm

+tonyg, +cpu, +simonjam as FYI in case this does regress performance (might be
conflated with aura changes)

[commit-bot: I haz the power, 2013-09-19 23:28:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wfh@chromium.org/23464081/9001

[commit-bot: I haz the power, 2013-09-20 02:09:11]

Retried try job too often on win_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-09-20 12:29:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wfh@chromium.org/23464081/9001

[commit-bot: I haz the power, 2013-09-20 14:36:31]

Retried try job too often on win_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[cpu_(ooo_6.6-7.5), 2013-09-20 15:29:37]

we are very close before cutting the branch, please hold on doing this until
after the branch. That is until Tuesday.

[cpu_(ooo_6.6-7.5), 2013-09-24 22:35:30]

lgtm

[commit-bot: I haz the power, 2013-09-27 19:08:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wfh@chromium.org/23464081/9001

[commit-bot: I haz the power, 2013-09-27 21:07:45]

Retried try job too often on linux_aura for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura...

[commit-bot: I haz the power, 2013-10-01 14:17:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wfh@chromium.org/23464081/9001

[commit-bot: I haz the power, 2013-10-01 16:39:33]

Retried try job too often on win_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-10-02 10:22:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wfh@chromium.org/23464081/9001

[commit-bot: I haz the power, 2013-10-02 10:31:34]

Change committed as 226446

[Will Harris, 2013-10-04 01:10:34]

crbug.com/132037 is now fixed so almost there!

[commit-bot: I haz the power, 2013-10-04 10:40:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wfh@chromium.org/23464081/9001

[commit-bot: I haz the power, 2013-10-04 11:14:40]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...

[Will Harris, 2013-10-17 13:33:24]

think I now have all remaining issues fixed.  Trying to commit again!

[commit-bot: I haz the power, 2013-10-17 13:39:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wfh@chromium.org/23464081/9001

[commit-bot: I haz the power, 2013-10-17 20:55:28]

Change committed as 229222

[Sigurður Ásgeirsson, 2013-10-18 13:52:29]

Looks like this change broke the latest official canary quite badly.