Change _ITERATOR_DEBUG_LEVEL to 1 on Release builds

build/common.gypi

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # IMPORTANT:
 # Please don't directly include this file if you are building via gyp_chromium,
 # since gyp_chromium is automatically forcing its inclusion.
 {
   # Variables expected to be overriden on the GYP command line (-D) or by
   # ~/.gyp/include.gypi.
@@ skipping 2658 matching lines @@
               }],
               ['win_release_OmitFramePointers==0', {
                 'OmitFramePointers': 'false',
                 # The above is not sufficient (http://crbug.com/106711): it
                 # simply eliminates an explicit "/Oy", but both /O2 and /Ox
                 # perform FPO regardless, so we must explicitly disable.
                 # We still want the false setting above to avoid having
                 # "/Oy /Oy-" and warnings about overriding.
                 'AdditionalOptions': ['/Oy-'],
               }],
+              ['win_debug_disable_iterator_debugging!=1', {

[scottmg, 2013/09/18 19:03:49]

is this used elsewhere? it really shouldn't be called win_"debug" if it's
affecting the release config.

[Will Harris, 2013/09/19 09:40:57]

added a new win_release_disable_iterator_debugging

it's not used anywhere else. it's just for the tsan/drmemory builds

+                # VS2010 changed default _ITERATOR_DEBUG_LEVEL to 0
+                # on Release builds so we change it back to 1 to restore these
+                # checks, except if explicitly disabled
+                # See http://crbug.com/289691
+                'PreprocessorDefinitions': ['_ITERATOR_DEBUG_LEVEL=1'],
+              }],
             ],
             'AdditionalOptions': [ '<@(win_release_extra_cflags)', ],
           },
           'VCLinkerTool': {
             # LinkIncremental is a tri-state boolean, where 0 means default
             # (i.e., inherit from parent solution), 1 means false, and
             # 2 means true.
             'LinkIncremental': '1',
             # This corresponds to the /PROFILE flag which ensures the PDB
             # file contains FIXUP information (growing the PDB file by about
@@ skipping 2056 matching lines @@
     # settings in target dicts.  SYMROOT is a special case, because many other
     # Xcode variables depend on it, including variables such as
     # PROJECT_DERIVED_FILE_DIR.  When a source group corresponding to something
     # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
     # files to appear (when present) in the UI as actual files and not red
     # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
     # and therefore SYMROOT, needs to be set at the project level.
     'SYMROOT': '<(DEPTH)/xcodebuild',
   },
 }