MD History: Update history-toolbar to use icon-button-light

MD History: Make icons in history-toolbar consistent.

This switches the icons to paper-icon-button-light, using the same
styling as elsewhere on the page. This doesn't actually improve page
load time, since all of these buttons are behind dom-ifs. It does,
however, simplify the CSS and make the Grouped mode buttons match the
mocks.

BUG=589357
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/a861123bdff0b6bc2963b0a2764104704c753b80
Cr-Commit-Position: refs/heads/master@{#437972}

[tsergeant, 2016-09-20 04:10:52]

Description was changed from

==========
MD History: Update history-toolbar to use icon-button-light

This doesn't actually improve page load time, since all of these buttons
are behind dom-ifs. However, I've taken the opportunity to simplify the
CSS and make the grouped nav buttons match the mocks more closely.

BUG=425625
==========

to

==========
MD History: Update history-toolbar to use icon-button-light

This doesn't actually improve page load time, since all of these buttons
are behind dom-ifs. However, I've taken the opportunity to simplify the
CSS and make the grouped nav buttons match the mocks more closely.

BUG=425625
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tsergeant, 2016-12-08 04:29:29]

Description was changed from

==========
MD History: Update history-toolbar to use icon-button-light

This doesn't actually improve page load time, since all of these buttons
are behind dom-ifs. However, I've taken the opportunity to simplify the
CSS and make the grouped nav buttons match the mocks more closely.

BUG=425625
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD History: Make icons in history-toolbar consistent.

This switches the icons to paper-icon-button-light, using the same
styling as elsewhere on the page. This doesn't actually improve page
load time, since all of these buttons are behind dom-ifs. It does,
however, simplify the CSS and make the Grouped mode buttons match the
mocks.

BUG=589357
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tsergeant, 2016-12-08 04:29:59]

Description was changed from

==========
MD History: Make icons in history-toolbar consistent.

This switches the icons to paper-icon-button-light, using the same
styling as elsewhere on the page. This doesn't actually improve page
load time, since all of these buttons are behind dom-ifs. It does,
however, simplify the CSS and make the Grouped mode buttons match the
mocks.

BUG=589357
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD History: Make icons in history-toolbar consistent.

This switches the icons to paper-icon-button-light, using the same
styling as elsewhere on the page. This doesn't actually improve page
load time, since all of these buttons are behind dom-ifs. It does,
however, simplify the CSS and make the Grouped mode buttons match the
mocks.

BUG=589357
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tsergeant, 2016-12-08 04:33:38]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-08 04:33:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tsergeant, 2016-12-08 04:43:19]

Patchset #1 (id:1) has been deleted

[tsergeant, 2016-12-08 04:43:58]

tsergeant@chromium.org changed reviewers:
+ calamity@chromium.org

[tsergeant, 2016-12-08 04:43:58]

Just in case you were looking for another CSS code review.

[commit-bot: I haz the power, 2016-12-08 05:26:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 05:26:58]

Dry run: This issue passed the CQ dry run.

[calamity, 2016-12-12 05:03:16]

lgtm

https://codereview.chromium.org/2346383004/diff/20001/chrome/browser/resource...
File chrome/browser/resources/md_history/history_toolbar.html (right):

https://codereview.chromium.org/2346383004/diff/20001/chrome/browser/resource...
chrome/browser/resources/md_history/history_toolbar.html:23: /* General toolbar
layout. */
I like these.

https://codereview.chromium.org/2346383004/diff/20001/chrome/browser/resource...
chrome/browser/resources/md_history/history_toolbar.html:83: margin: 0 4px;
This doesn't seem to do anything?

https://codereview.chromium.org/2346383004/diff/20001/chrome/browser/resource...
chrome/browser/resources/md_history/history_toolbar.html:128:
-webkit-margin-start: 32px;
Hmm, just noticed that the mocks say this should be moved in even more (aligned
with the card). Unfortunately, our dates are also currently way too long so we
need to deal with that too...

[tsergeant, 2016-12-12 06:33:32]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-12 06:33:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-12 08:45:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-12 08:45:11]

Dry run: This issue passed the CQ dry run.

[tsergeant, 2016-12-12 23:54:57]

https://codereview.chromium.org/2346383004/diff/20001/chrome/browser/resource...
File chrome/browser/resources/md_history/history_toolbar.html (right):

https://codereview.chromium.org/2346383004/diff/20001/chrome/browser/resource...
chrome/browser/resources/md_history/history_toolbar.html:83: margin: 0 4px;
On 2016/12/12 05:03:16, calamity wrote:
> This doesn't seem to do anything?

You're right. I started this patch months ago, so I'm not sure what this was
meant to achieve.

Deleted.

https://codereview.chromium.org/2346383004/diff/20001/chrome/browser/resource...
chrome/browser/resources/md_history/history_toolbar.html:128:
-webkit-margin-start: 32px;
On 2016/12/12 05:03:16, calamity wrote:
> Hmm, just noticed that the mocks say this should be moved in even more
(aligned
> with the card). Unfortunately, our dates are also currently way too long so we
> need to deal with that too...

Acknowledged. This will be a fair amount of work, so I'll defer to a follow-up?

[calamity, 2016-12-13 00:45:23]

https://codereview.chromium.org/2346383004/diff/20001/chrome/browser/resource...
File chrome/browser/resources/md_history/history_toolbar.html (right):

https://codereview.chromium.org/2346383004/diff/20001/chrome/browser/resource...
chrome/browser/resources/md_history/history_toolbar.html:128:
-webkit-margin-start: 32px;
On 2016/12/12 23:54:57, tsergeant wrote:
> On 2016/12/12 05:03:16, calamity wrote:
> > Hmm, just noticed that the mocks say this should be moved in even more
> (aligned
> > with the card). Unfortunately, our dates are also currently way too long so
we
> > need to deal with that too...
> 
> Acknowledged. This will be a fair amount of work, so I'll defer to a
follow-up?

Yeah, for sure. I might take a look at date formatting nonsense.

[tsergeant, 2016-12-13 00:46:20]

The CQ bit was checked by tsergeant@chromium.org

[tsergeant, 2016-12-13 00:46:21]

The patchset sent to the CQ was uploaded after l-g-t-m from
calamity@chromium.org
Link to the patchset: https://codereview.chromium.org/2346383004/#ps40001
(title: "Review comments")

[commit-bot: I haz the power, 2016-12-13 00:47:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 00:54:12]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481589980689610,
"parent_rev": "d9dfe9cb8a71cecd70b146311df2b5eabc87a3b9", "commit_rev":
"d7f7438aca906d8600acbdaa69a96841c4b091d4"}

[commit-bot: I haz the power, 2016-12-13 00:54:48]

Description was changed from

==========
MD History: Make icons in history-toolbar consistent.

This switches the icons to paper-icon-button-light, using the same
styling as elsewhere on the page. This doesn't actually improve page
load time, since all of these buttons are behind dom-ifs. It does,
however, simplify the CSS and make the Grouped mode buttons match the
mocks.

BUG=589357
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD History: Make icons in history-toolbar consistent.

This switches the icons to paper-icon-button-light, using the same
styling as elsewhere on the page. This doesn't actually improve page
load time, since all of these buttons are behind dom-ifs. It does,
however, simplify the CSS and make the Grouped mode buttons match the
mocks.

BUG=589357
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2346383004
==========

[commit-bot: I haz the power, 2016-12-13 00:54:50]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-12-13 00:56:34]

Description was changed from

==========
MD History: Make icons in history-toolbar consistent.

This switches the icons to paper-icon-button-light, using the same
styling as elsewhere on the page. This doesn't actually improve page
load time, since all of these buttons are behind dom-ifs. It does,
however, simplify the CSS and make the Grouped mode buttons match the
mocks.

BUG=589357
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2346383004
==========

to

==========
MD History: Make icons in history-toolbar consistent.

This switches the icons to paper-icon-button-light, using the same
styling as elsewhere on the page. This doesn't actually improve page
load time, since all of these buttons are behind dom-ifs. It does,
however, simplify the CSS and make the Grouped mode buttons match the
mocks.

BUG=589357
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/a861123bdff0b6bc2963b0a2764104704c753b80
Cr-Commit-Position: refs/heads/master@{#437972}
==========

[commit-bot: I haz the power, 2016-12-13 00:56:35]

Patchset 2 (id:??) landed as
https://crrev.com/a861123bdff0b6bc2963b0a2764104704c753b80
Cr-Commit-Position: refs/heads/master@{#437972}