Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2346353002: Revert of Set crash key if WM_QUIT message is received on GPU message loop. (Closed)

Created:
4 years, 3 months ago by jbauman
Modified:
4 years, 3 months ago
CC:
chromium-reviews, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Set crash key if WM_QUIT message is received on GPU message loop. (patchset #3 id:40001 of https://codereview.chromium.org/2342713002/ ) Reason for revert: We've got enough data now. Original issue's description: > Set crash key if WM_QUIT message is received on GPU message loop. > > Threads seem to be exiting unexpectedly, so to help debugging set a > crash key if an unexpected WM_QUIT message is received. > > BUG=647068 > TBR=scottmg@chromium.org > > Committed: https://crrev.com/18db6b0cc6f81fba74278cfab2856ccb11c0e0c7 > Cr-Commit-Position: refs/heads/master@{#419057} TBR=dcheng@chromium.org,scottmg@chromium.org,rsesek@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=647068 Committed: https://crrev.com/e9236744e4bef532498c0c5deb3bc7a833197464 Cr-Commit-Position: refs/heads/master@{#419543}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -15 lines) Patch
M base/message_loop/message_pump_win.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M blimp/engine/app/blimp_engine_crash_keys.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/app/chrome_crash_reporter_client_win.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/common/crash_keys.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
jbauman
Created Revert of Set crash key if WM_QUIT message is received on GPU message loop.
4 years, 3 months ago (2016-09-19 18:58:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2346353002/1
4 years, 3 months ago (2016-09-19 18:59:06 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-19 20:10:24 UTC) #4
commit-bot: I haz the power
4 years, 3 months ago (2016-09-19 21:03:27 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e9236744e4bef532498c0c5deb3bc7a833197464
Cr-Commit-Position: refs/heads/master@{#419543}

Powered by Google App Engine
This is Rietveld 408576698