Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Side by Side Diff: chrome/app/chrome_crash_reporter_client_win.cc

Issue 2346353002: Revert of Set crash key if WM_QUIT message is received on GPU message loop. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « blimp/engine/app/blimp_engine_crash_keys.cc ('k') | chrome/common/crash_keys.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // TODO(ananta/scottmg) 5 // TODO(ananta/scottmg)
6 // Add test coverage for Crashpad. 6 // Add test coverage for Crashpad.
7 #include "chrome/app/chrome_crash_reporter_client_win.h" 7 #include "chrome/app/chrome_crash_reporter_client_win.h"
8 8
9 #include <assert.h> 9 #include <assert.h>
10 #include <windows.h> 10 #include <windows.h>
(...skipping 161 matching lines...) Expand 10 before | Expand all | Expand 10 after
172 {"swdh_register_cannot_scope_url", crash_keys::kLargeSize}, 172 {"swdh_register_cannot_scope_url", crash_keys::kLargeSize},
173 {"swdh_register_cannot_script_url", crash_keys::kLargeSize}, 173 {"swdh_register_cannot_script_url", crash_keys::kLargeSize},
174 174
175 // Temporary for https://crbug.com/619294. 175 // Temporary for https://crbug.com/619294.
176 {"swdh_unregister_cannot_host_url", crash_keys::kLargeSize}, 176 {"swdh_unregister_cannot_host_url", crash_keys::kLargeSize},
177 {"swdh_unregister_cannot_scope_url", crash_keys::kLargeSize}, 177 {"swdh_unregister_cannot_scope_url", crash_keys::kLargeSize},
178 178
179 // Temporary for https://crbug.com/630496. 179 // Temporary for https://crbug.com/630496.
180 {"swdh_get_registration_cannot_host_url", crash_keys::kLargeSize}, 180 {"swdh_get_registration_cannot_host_url", crash_keys::kLargeSize},
181 {"swdh_get_registration_cannot_document_url", crash_keys::kLargeSize}, 181 {"swdh_get_registration_cannot_document_url", crash_keys::kLargeSize},
182
183 // Temporary for https://crbug.com/647068.
184 {"received_quit_message", crash_keys::kSmallSize},
185 }; 182 };
186 183
187 // This dynamic set of keys is used for sets of key value pairs when gathering 184 // This dynamic set of keys is used for sets of key value pairs when gathering
188 // a collection of data, like command line switches or extension IDs. 185 // a collection of data, like command line switches or extension IDs.
189 std::vector<base::debug::CrashKey> keys(fixed_keys, 186 std::vector<base::debug::CrashKey> keys(fixed_keys,
190 fixed_keys + arraysize(fixed_keys)); 187 fixed_keys + arraysize(fixed_keys));
191 188
192 crash_keys::GetCrashKeysForCommandLineSwitches(&keys); 189 crash_keys::GetCrashKeysForCommandLineSwitches(&keys);
193 190
194 // Register the extension IDs. 191 // Register the extension IDs.
(...skipping 184 matching lines...) Expand 10 before | Expand all | Expand 10 after
379 bool ChromeCrashReporterClient::GetCollectStatsInSample() { 376 bool ChromeCrashReporterClient::GetCollectStatsInSample() {
380 return install_static::GetCollectStatsInSample(); 377 return install_static::GetCollectStatsInSample();
381 } 378 }
382 379
383 bool ChromeCrashReporterClient::EnableBreakpadForProcess( 380 bool ChromeCrashReporterClient::EnableBreakpadForProcess(
384 const std::string& process_type) { 381 const std::string& process_type) {
385 return process_type == install_static::kRendererProcess || 382 return process_type == install_static::kRendererProcess ||
386 process_type == install_static::kPpapiPluginProcess || 383 process_type == install_static::kPpapiPluginProcess ||
387 process_type == install_static::kGpuProcess; 384 process_type == install_static::kGpuProcess;
388 } 385 }
OLDNEW
« no previous file with comments | « blimp/engine/app/blimp_engine_crash_keys.cc ('k') | chrome/common/crash_keys.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698