Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 23463010: Revert "Added a new base::strings::SafeSPrintf() function that can" (Closed)

Created:
7 years, 3 months ago by tkent
Modified:
7 years, 3 months ago
Reviewers:
Markus (顧孟勤)
CC:
chromium-reviews, erikwright+watch_chromium.org, jshin+watch_chromium.org
Visibility:
Public.

Description

Revert "Added a new base::strings::SafeSPrintf() function that can" Revert "Disable EmitNULL test for Widows x64." This reverts r220773 and 220746. r220746 broke ChromiumOS build. BUG=283595 TBR=markus@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220777

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1893 lines) Patch
M base/base.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M base/base.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
D base/strings/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
D base/strings/safe_sprintf.h View 1 chunk +0 lines, -439 lines 0 comments Download
D base/strings/safe_sprintf.cc View 1 chunk +0 lines, -681 lines 0 comments Download
D base/strings/safe_sprintf_unittest.cc View 1 chunk +0 lines, -769 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tkent
http://build.chromium.org/p/chromium.chromiumos/builders/ChromiumOS%20%28daisy%29/builds/12342/steps/cbuildbot/logs/stdio chromeos-chrome-31.0.1619.0_alpha-r1: In file included from strings/safe_sprintf.cc:5:0: chromeos-chrome-31.0.1619.0_alpha-r1: ../base/strings/safe_sprintf.h:178:13: error: 'ssize_t' does not name a ...
7 years, 3 months ago (2013-09-02 03:25:39 UTC) #1
tkent
Committed patchset #1 manually as r220777.
7 years, 3 months ago (2013-09-02 03:26:12 UTC) #2
Markus (顧孟勤)
That looks as if ChromeOS has slightly incomplete system headers. But it's easy enough to ...
7 years, 3 months ago (2013-09-02 05:58:07 UTC) #3
tkent
7 years, 3 months ago (2013-09-02 06:00:22 UTC) #4
Message was sent while issue was closed.
Unfortunately I don't know.  I'm not a ChromeOS engineer.

Powered by Google App Engine
This is Rietveld 408576698