Issue 23463007: file_manager: Fix a bug where hosted documents could not be opened without active browser window.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23463007: file_manager: Fix a bug where hosted documents could not be opened without active browser window. (Closed)

Created:
7 years, 3 months ago by satorux1

Modified:
7 years, 3 months ago

Reviewers:
kinaba

CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, rginda+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

file_manager: Fix a bug where hosted documents could not be opened without active browser window. This is likely a regression caused by r219217. Previously, hosted documents were opened with fileBrowserPrivate.viewFiles(), but r219217 replaced viewFiles() with executeTask(). The logic in executeTask() didn't handle the case where there were no active browser windows correctly. BUG=280936 TEST=see the bug R=kinaba@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220522

Patch Set 1 : #

Patch Set 2 : rebase #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+31 lines, -24 lines)			Patch
M	chrome/browser/chromeos/extensions/file_manager/file_browser_handlers.cc	View	1 chunk	+3 lines, -10 lines	0 comments	Download
M	chrome/browser/chromeos/extensions/file_manager/open_with_browser.h	View	2 chunks	+4 lines, -3 lines	0 comments	Download
M	chrome/browser/chromeos/extensions/file_manager/open_with_browser.cc	View	7 chunks	+24 lines, -11 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

satorux1

7 years, 3 months ago (2013-08-30 06:45:52 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r220522 (presubmit successful).

Expand Messages | Collapse Messages