chrome/browser/chromeos/extensions/file_manager/open_with_browser.h - Issue 23463007: file_manager: Fix a bug where hosted documents could not be opened without active browser window.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/extensions/file_manager/open_with_browser.h

Issue 23463007: file_manager: Fix a bug where hosted documents could not be opened without active browser window. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/extensions/file_manager/file_browser_handlers.cc ('k') | chrome/browser/chromeos/extensions/file_manager/open_with_browser.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/extensions/file_manager/open_with_browser.h

diff --git a/chrome/browser/chromeos/extensions/file_manager/open_with_browser.h b/chrome/browser/chromeos/extensions/file_manager/open_with_browser.h

index dfcdc05f617d76a8bd057f22fd039df2f3a9a7a8..66e09a9df2a921f439e7bcce2f374ec6ce9ceb95 100644

--- a/chrome/browser/chromeos/extensions/file_manager/open_with_browser.h

+++ b/chrome/browser/chromeos/extensions/file_manager/open_with_browser.h

@@ -15,9 +15,10 @@ class Profile;

namespace file_manager {

namespace util {

-// Opens the file specified by |file_path| with the browser. This function takes

-// care of the following intricacies:

+// Opens the file specified by |file_path| with the browser for

+// |profile|. This function takes care of the following intricacies:

+// - If there is no active browser window, open it.

// - If the file is a Drive hosted document, the hosted document will be

// opened in the browser by extracting the right URL for the file.

// - If the file is a CRX file, the CRX file will be installed.

@@ -25,7 +26,7 @@ namespace util {

// needed.

// Returns false if failed to open. This happens if the file type is unknown.

-bool OpenFileWithBrowser(Browser* browser, const base::FilePath& file_path);

+bool OpenFileWithBrowser(Profile* profile, const base::FilePath& file_path);

// Checks whether a pepper plugin for |file_extension| is enabled.

bool ShouldBeOpenedWithPlugin(