Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Issue 2346253004: Makes display roots be destroyed by client (Closed)

Created:
4 years, 3 months ago by sky
Modified:
4 years, 3 months ago
Reviewers:
Tom Sepez, sadrul
CC:
chromium-reviews, rjkroege, sadrul, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, kalyank, darin (slow to review)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Makes display roots be destroyed by client Prior to this patch when a display was destroyed the client would get a delete notification for the root. This is problematic as the client may need to delete the root after a delay (as happens in ash). This patch changes it so the client is notified of the display removal and it's up to the client to then delete the window when they want to. BUG=647512 TEST=covered by tests R=sadrul@chromium.org Committed: https://crrev.com/54ff2ccef79fedc2a991f9c9b66e64d0c781cfc5 Cr-Commit-Position: refs/heads/master@{#419658}

Patch Set 1 #

Patch Set 2 : cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+316 lines, -62 lines) Patch
M ash/mus/window_manager.h View 1 chunk +1 line, -0 lines 0 comments Download
M ash/mus/window_manager.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M services/ui/demo/mus_demo.h View 1 chunk +1 line, -0 lines 0 comments Download
M services/ui/demo/mus_demo.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M services/ui/public/cpp/tests/window_server_test_base.h View 1 chunk +1 line, -0 lines 0 comments Download
M services/ui/public/cpp/tests/window_server_test_base.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M services/ui/public/cpp/window_manager_delegate.h View 1 chunk +3 lines, -0 lines 0 comments Download
M services/ui/public/cpp/window_tree_client.h View 1 chunk +1 line, -0 lines 0 comments Download
M services/ui/public/cpp/window_tree_client.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M services/ui/public/interfaces/window_manager.mojom View 1 chunk +5 lines, -0 lines 0 comments Download
M services/ui/test_wm/test_wm.cc View 1 chunk +1 line, -0 lines 0 comments Download
M services/ui/ws/display.h View 1 chunk +1 line, -1 line 0 comments Download
M services/ui/ws/display.cc View 5 chunks +17 lines, -10 lines 0 comments Download
M services/ui/ws/display_unittest.cc View 1 1 chunk +93 lines, -0 lines 0 comments Download
M services/ui/ws/test_utils.h View 5 chunks +8 lines, -1 line 0 comments Download
M services/ui/ws/test_utils.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M services/ui/ws/window_manager_client_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M services/ui/ws/window_manager_display_root.h View 1 chunk +1 line, -0 lines 0 comments Download
M services/ui/ws/window_manager_state.h View 8 chunks +35 lines, -1 line 0 comments Download
M services/ui/ws/window_manager_state.cc View 5 chunks +63 lines, -28 lines 0 comments Download
M services/ui/ws/window_server.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M services/ui/ws/window_tree.h View 2 chunks +5 lines, -0 lines 0 comments Download
M services/ui/ws/window_tree.cc View 1 4 chunks +38 lines, -21 lines 0 comments Download
M services/ui/ws/window_tree_client_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 17 (9 generated)
sky
4 years, 3 months ago (2016-09-19 21:04:13 UTC) #1
sky
+tsepez for mojom
4 years, 3 months ago (2016-09-19 21:19:12 UTC) #6
Tom Sepez
mojom LGTM
4 years, 3 months ago (2016-09-19 21:54:08 UTC) #7
sadrul
lgtm The 'clients' referred to in the CL description are window managers, right? When reviewing ...
4 years, 3 months ago (2016-09-20 01:37:10 UTC) #10
sky
You are right that this only applies to the WindowManager. DisplayBinding is only used if ...
4 years, 3 months ago (2016-09-20 02:38:43 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2346253004/20001
4 years, 3 months ago (2016-09-20 02:39:11 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-20 02:44:59 UTC) #15
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 02:47:39 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/54ff2ccef79fedc2a991f9c9b66e64d0c781cfc5
Cr-Commit-Position: refs/heads/master@{#419658}

Powered by Google App Engine
This is Rietveld 408576698