Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 2352893002: Makes windowserver not send messages during shutdown (Closed)

Created:
4 years, 3 months ago by sky
Modified:
4 years, 3 months ago
Reviewers:
sadrul
CC:
chromium-reviews, rjkroege
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Makes windowserver not send messages during shutdown To send messages during shutdown means clients may process messages in weird order. The windowserver should not send any messages during shutdown. The client can detect connection loss and take whatever action is appropriate. It may be we want a specific message to indicate the windowserver is going down normally vs a crash, but for now I'm only making it so no messages are sent. BUG=648435 TEST=covered by test R=sadrul@chromium.org Committed: https://crrev.com/20e6c7ecccbcd292abc95fe906bd987cf9cb2bf2 Cr-Commit-Position: refs/heads/master@{#419670}

Patch Set 1 #

Patch Set 2 : cleanup #

Patch Set 3 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -15 lines) Patch
M services/ui/ws/test_utils.h View 1 3 chunks +16 lines, -3 lines 0 comments Download
M services/ui/ws/test_utils.cc View 1 3 chunks +15 lines, -4 lines 0 comments Download
M services/ui/ws/window_server.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M services/ui/ws/window_tree.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M services/ui/ws/window_tree.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M services/ui/ws/window_tree_binding.h View 1 2 chunks +11 lines, -0 lines 0 comments Download
M services/ui/ws/window_tree_binding.cc View 3 chunks +18 lines, -8 lines 0 comments Download
M services/ui/ws/window_tree_unittest.cc View 1 2 chunks +36 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
sky
4 years, 3 months ago (2016-09-19 22:40:52 UTC) #1
sadrul
Yeah, I think we are going to need a specific message at some point (especially ...
4 years, 3 months ago (2016-09-20 01:53:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2352893002/40001
4 years, 3 months ago (2016-09-20 02:54:24 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-20 03:43:45 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 03:46:14 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/20e6c7ecccbcd292abc95fe906bd987cf9cb2bf2
Cr-Commit-Position: refs/heads/master@{#419670}

Powered by Google App Engine
This is Rietveld 408576698