Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 23462007: Delete HAbnormalExit. It does more harm than good. (Closed)

Created:
7 years, 3 months ago by Jakob Kummerow
Modified:
7 years, 3 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Delete HAbnormalExit. It does more harm than good. BUG=v8:2843 R=mstarzinger@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=16406

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -57 lines) Patch
M src/arm/lithium-arm.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/hydrogen.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/hydrogen-environment-liveness.cc View 1 chunk +1 line, -5 lines 0 comments Download
M src/hydrogen-instructions.h View 2 chunks +0 lines, -11 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/mips/lithium-mips.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/x64/lithium-x64.cc View 1 chunk +0 lines, -7 lines 0 comments Download
A + test/mjsunit/regress/regress-2843.js View 1 chunk +12 lines, -11 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Jakob Kummerow
Fixed bug by deleting code -- please take a look.
7 years, 3 months ago (2013-08-28 13:31:06 UTC) #1
Michael Starzinger
LGTM.
7 years, 3 months ago (2013-08-28 13:46:23 UTC) #2
Jakob Kummerow
7 years, 3 months ago (2013-08-28 15:00:46 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r16406 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698