Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Side by Side Diff: src/hydrogen.cc

Issue 23462007: Delete HAbnormalExit. It does more harm than good. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/lithium-arm.cc ('k') | src/hydrogen-environment-liveness.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 5388 matching lines...) Expand 10 before | Expand all | Expand 10 after
5399 // We don't optimize functions with invalid left-hand sides in 5399 // We don't optimize functions with invalid left-hand sides in
5400 // assignments, count operations, or for-in. Consequently throw can 5400 // assignments, count operations, or for-in. Consequently throw can
5401 // currently only occur in an effect context. 5401 // currently only occur in an effect context.
5402 ASSERT(ast_context()->IsEffect()); 5402 ASSERT(ast_context()->IsEffect());
5403 CHECK_ALIVE(VisitForValue(expr->exception())); 5403 CHECK_ALIVE(VisitForValue(expr->exception()));
5404 5404
5405 HValue* value = environment()->Pop(); 5405 HValue* value = environment()->Pop();
5406 HThrow* instr = Add<HThrow>(value); 5406 HThrow* instr = Add<HThrow>(value);
5407 instr->set_position(expr->position()); 5407 instr->set_position(expr->position());
5408 Add<HSimulate>(expr->id()); 5408 Add<HSimulate>(expr->id());
5409 current_block()->FinishExit(new(zone()) HAbnormalExit);
5410 set_current_block(NULL);
5411 } 5409 }
5412 5410
5413 5411
5414 HLoadNamedField* HGraphBuilder::BuildLoadNamedField(HValue* object, 5412 HLoadNamedField* HGraphBuilder::BuildLoadNamedField(HValue* object,
5415 HObjectAccess access) { 5413 HObjectAccess access) {
5416 if (FLAG_track_double_fields && access.representation().IsDouble()) { 5414 if (FLAG_track_double_fields && access.representation().IsDouble()) {
5417 // load the heap number 5415 // load the heap number
5418 HLoadNamedField* heap_number = Add<HLoadNamedField>( 5416 HLoadNamedField* heap_number = Add<HLoadNamedField>(
5419 object, access.WithRepresentation(Representation::Tagged())); 5417 object, access.WithRepresentation(Representation::Tagged()));
5420 heap_number->set_type(HType::HeapNumber()); 5418 heap_number->set_type(HType::HeapNumber());
(...skipping 4464 matching lines...) Expand 10 before | Expand all | Expand 10 after
9885 if (ShouldProduceTraceOutput()) { 9883 if (ShouldProduceTraceOutput()) {
9886 isolate()->GetHTracer()->TraceHydrogen(name(), graph_); 9884 isolate()->GetHTracer()->TraceHydrogen(name(), graph_);
9887 } 9885 }
9888 9886
9889 #ifdef DEBUG 9887 #ifdef DEBUG
9890 graph_->Verify(false); // No full verify. 9888 graph_->Verify(false); // No full verify.
9891 #endif 9889 #endif
9892 } 9890 }
9893 9891
9894 } } // namespace v8::internal 9892 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/arm/lithium-arm.cc ('k') | src/hydrogen-environment-liveness.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698