Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Unified Diff: third_party/WebKit/Source/core/html/HTMLTableElement.cpp

Issue 2346193002: Split CSSPrimitiveValue into CSSPrimitiveValue and CSSIdentifierValue (Closed)
Patch Set: Rebase please work Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLTableElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLTableElement.cpp b/third_party/WebKit/Source/core/html/HTMLTableElement.cpp
index 481cb8c5939787ec52e462469940a9361da19555..8a7b51aea0a4a4ee59c371fcefe84d8f7a2c7c68 100644
--- a/third_party/WebKit/Source/core/html/HTMLTableElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLTableElement.cpp
@@ -29,9 +29,9 @@
#include "core/CSSPropertyNames.h"
#include "core/CSSValueKeywords.h"
#include "core/HTMLNames.h"
+#include "core/css/CSSIdentifierValue.h"
#include "core/css/CSSImageValue.h"
#include "core/css/CSSInheritedValue.h"
-#include "core/css/CSSPrimitiveValue.h"
#include "core/css/StylePropertySet.h"
#include "core/dom/Attribute.h"
#include "core/dom/ElementTraversal.h"
@@ -468,12 +468,12 @@ StylePropertySet* HTMLTableElement::createSharedCellStyle()
break;
case SolidBorders:
style->setProperty(CSSPropertyBorderWidth, *CSSPrimitiveValue::create(1, CSSPrimitiveValue::UnitType::Pixels));
- style->setProperty(CSSPropertyBorderStyle, *CSSPrimitiveValue::createIdentifier(CSSValueSolid));
+ style->setProperty(CSSPropertyBorderStyle, *CSSIdentifierValue::create(CSSValueSolid));
style->setProperty(CSSPropertyBorderColor, *CSSInheritedValue::create());
break;
case InsetBorders:
style->setProperty(CSSPropertyBorderWidth, *CSSPrimitiveValue::create(1, CSSPrimitiveValue::UnitType::Pixels));
- style->setProperty(CSSPropertyBorderStyle, *CSSPrimitiveValue::createIdentifier(CSSValueInset));
+ style->setProperty(CSSPropertyBorderStyle, *CSSIdentifierValue::create(CSSValueInset));
style->setProperty(CSSPropertyBorderColor, *CSSInheritedValue::create());
break;
case NoBorders:

Powered by Google App Engine
This is Rietveld 408576698