third_party/WebKit/Source/core/editing/serializers/Serialization.cpp - Issue 2346193002: Split CSSPrimitiveValue into CSSPrimitiveValue and CSSIdentifierValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/serializers/Serialization.cpp

Issue 2346193002: Split CSSPrimitiveValue into CSSPrimitiveValue and CSSIdentifierValue (Closed)

Patch Set: Rebase please work Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp ('k') | third_party/WebKit/Source/core/html/HTMLTableElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/serializers/Serialization.cpp

diff --git a/third_party/WebKit/Source/core/editing/serializers/Serialization.cpp b/third_party/WebKit/Source/core/editing/serializers/Serialization.cpp

index dd439d69fc273aadb77ca6f861ab682bb3f79260..e3247c96bc0b747c98eaa4a7ef773cd430b83047 100644

--- a/third_party/WebKit/Source/core/editing/serializers/Serialization.cpp

+++ b/third_party/WebKit/Source/core/editing/serializers/Serialization.cpp

@@ -31,7 +31,7 @@

#include "bindings/core/v8/ExceptionState.h"

#include "core/CSSValueKeywords.h"

#include "core/HTMLNames.h"

-#include "core/css/CSSPrimitiveValue.h"

+#include "core/css/CSSIdentifierValue.h"

#include "core/css/CSSValue.h"

#include "core/css/StylePropertySet.h"

#include "core/dom/CDATASection.h"

@@ -163,9 +163,9 @@ bool propertyMissingOrEqualToNone(StylePropertySet* style, CSSPropertyID propert

const CSSValue* value = style->getPropertyCSSValue(propertyID);

if (!value)

return true;

- if (!value->isPrimitiveValue())

+ if (!value->isIdentifierValue())

return false;

- return toCSSPrimitiveValue(value)->getValueID() == CSSValueNone;

+ return toCSSIdentifierValue(value)->getValueID() == CSSValueNone;

}

template<typename Strategy>