third_party/WebKit/Source/core/css/cssom/CSSKeywordValue.cpp - Issue 2346193002: Split CSSPrimitiveValue into CSSPrimitiveValue and CSSIdentifierValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/cssom/CSSKeywordValue.cpp

Issue 2346193002: Split CSSPrimitiveValue into CSSPrimitiveValue and CSSIdentifierValue (Closed)

Patch Set: Rebase please work Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/cssom/CSSKeywordValue.cpp

diff --git a/third_party/WebKit/Source/core/css/cssom/CSSKeywordValue.cpp b/third_party/WebKit/Source/core/css/cssom/CSSKeywordValue.cpp

index ac4648b8139535be2316009bf40a26fe78162a0f..06cef51efe7440be3801f9fd08379ab57dc09fac 100644

--- a/third_party/WebKit/Source/core/css/cssom/CSSKeywordValue.cpp

+++ b/third_party/WebKit/Source/core/css/cssom/CSSKeywordValue.cpp

@@ -6,7 +6,7 @@

#include "bindings/core/v8/ExceptionState.h"

#include "core/css/CSSCustomIdentValue.h"

-#include "core/css/CSSPrimitiveValue.h"

+#include "core/css/CSSIdentifierValue.h"

#include "core/css/parser/CSSPropertyParser.h"

namespace blink {

@@ -36,7 +36,7 @@ CSSValue* CSSKeywordValue::toCSSValue() const

if (keywordID == CSSValueID::CSSValueInvalid) {

return CSSCustomIdentValue::create(m_keywordValue);

}

- return CSSPrimitiveValue::createIdentifier(keywordID);

+ return CSSIdentifierValue::create(keywordID);

}

} // namespace blink