third_party/WebKit/Source/core/css/StylePropertySet.cpp - Issue 2346193002: Split CSSPrimitiveValue into CSSPrimitiveValue and CSSIdentifierValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/StylePropertySet.cpp

Issue 2346193002: Split CSSPrimitiveValue into CSSPrimitiveValue and CSSIdentifierValue (Closed)

Patch Set: Rebase please work Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/StylePropertySet.cpp

diff --git a/third_party/WebKit/Source/core/css/StylePropertySet.cpp b/third_party/WebKit/Source/core/css/StylePropertySet.cpp

index 42c1d084450bd2935f6ba9b97dc7526a65046829..1d0aa1e29aa6a82708d2d37b990ccd128a9597a7 100644

--- a/third_party/WebKit/Source/core/css/StylePropertySet.cpp

+++ b/third_party/WebKit/Source/core/css/StylePropertySet.cpp

@@ -24,7 +24,7 @@

#include "core/StylePropertyShorthand.h"

#include "core/css/CSSCustomPropertyDeclaration.h"

-#include "core/css/CSSPrimitiveValue.h"

+#include "core/css/CSSIdentifierValue.h"

#include "core/css/CSSPropertyMetadata.h"

#include "core/css/StylePropertySerializer.h"

#include "core/css/StyleSheetContents.h"

@@ -342,7 +342,7 @@ bool MutableStylePropertySet::setProperty(const CSSProperty& property, CSSProper

bool MutableStylePropertySet::setProperty(CSSPropertyID propertyID, CSSValueID identifier, bool important)

{

- setProperty(CSSProperty(propertyID, *CSSPrimitiveValue::createIdentifier(identifier), important));

+ setProperty(CSSProperty(propertyID, *CSSIdentifierValue::create(identifier), important));

return true;

}