third_party/WebKit/Source/core/animation/CSSFontWeightInterpolationType.cpp - Issue 2346193002: Split CSSPrimitiveValue into CSSPrimitiveValue and CSSIdentifierValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/CSSFontWeightInterpolationType.cpp

Issue 2346193002: Split CSSPrimitiveValue into CSSPrimitiveValue and CSSIdentifierValue (Closed)

Patch Set: Rebase please work Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/animation/CSSFontSizeInterpolationType.cpp ('k') | third_party/WebKit/Source/core/animation/CSSImageListInterpolationType.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/CSSFontWeightInterpolationType.cpp

diff --git a/third_party/WebKit/Source/core/animation/CSSFontWeightInterpolationType.cpp b/third_party/WebKit/Source/core/animation/CSSFontWeightInterpolationType.cpp

index f238148f2ff0ba067867ea9a9b43a110e127b916..ff85cb9484458dd71c8e89ab6b95bf278f008567 100644

--- a/third_party/WebKit/Source/core/animation/CSSFontWeightInterpolationType.cpp

+++ b/third_party/WebKit/Source/core/animation/CSSFontWeightInterpolationType.cpp

@@ -103,11 +103,11 @@ InterpolationValue CSSFontWeightInterpolationType::maybeConvertInherit(const Sty

InterpolationValue CSSFontWeightInterpolationType::maybeConvertValue(const CSSValue& value, const StyleResolverState& state, ConversionCheckers& conversionCheckers) const

{

- if (!value.isPrimitiveValue())

+ if (!value.isIdentifierValue())

return nullptr;

- const CSSPrimitiveValue& primitiveValue = toCSSPrimitiveValue(value);

- CSSValueID keyword = primitiveValue.getValueID();

+ const CSSIdentifierValue& identifierValue = toCSSIdentifierValue(value);

+ CSSValueID keyword = identifierValue.getValueID();

switch (keyword) {

case CSSValueInvalid:

@@ -123,7 +123,7 @@ InterpolationValue CSSFontWeightInterpolationType::maybeConvertValue(const CSSVa

}

default:

- return createFontWeightValue(primitiveValue.convertTo<FontWeight>());

+ return createFontWeightValue(identifierValue.convertTo<FontWeight>());

}