third_party/WebKit/Source/core/animation/CSSFontSizeInterpolationType.cpp - Issue 2346193002: Split CSSPrimitiveValue into CSSPrimitiveValue and CSSIdentifierValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/CSSFontSizeInterpolationType.cpp

Issue 2346193002: Split CSSPrimitiveValue into CSSPrimitiveValue and CSSIdentifierValue (Closed)

Patch Set: Rebase please work Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/animation/CSSFilterListInterpolationType.cpp ('k') | third_party/WebKit/Source/core/animation/CSSFontWeightInterpolationType.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/CSSFontSizeInterpolationType.cpp

diff --git a/third_party/WebKit/Source/core/animation/CSSFontSizeInterpolationType.cpp b/third_party/WebKit/Source/core/animation/CSSFontSizeInterpolationType.cpp

index ec3b822849e8f6883904e6308d7c2b3a1321ce39..706da1d1f22dbcd0c17becbaf70ae5dd7472da53 100644

--- a/third_party/WebKit/Source/core/animation/CSSFontSizeInterpolationType.cpp

+++ b/third_party/WebKit/Source/core/animation/CSSFontSizeInterpolationType.cpp

@@ -5,7 +5,7 @@

#include "core/animation/CSSFontSizeInterpolationType.h"

#include "core/animation/LengthInterpolationFunctions.h"

-#include "core/css/CSSPrimitiveValue.h"

+#include "core/css/CSSIdentifierValue.h"

#include "core/css/resolver/StyleResolverState.h"

#include "platform/LengthFunctions.h"

#include "platform/fonts/FontDescription.h"

@@ -103,10 +103,10 @@ InterpolationValue CSSFontSizeInterpolationType::maybeConvertValue(const CSSValu

if (result)

return InterpolationValue(std::move(result));

- if (!value.isPrimitiveValue() || !toCSSPrimitiveValue(value).isValueID())

+ if (!value.isIdentifierValue())

return nullptr;

- return maybeConvertKeyword(toCSSPrimitiveValue(value).getValueID(), state, conversionCheckers);

+ return maybeConvertKeyword(toCSSIdentifierValue(value).getValueID(), state, conversionCheckers);

}

InterpolationValue CSSFontSizeInterpolationType::maybeConvertUnderlyingValue(const InterpolationEnvironment& environment) const