Fix BUILD.gn files and add presubmit step

Fix BUILD.gn files and add presubmit step

Remove files that were removed from the build files but never deleted.

R=machenbach@chromium.org
BUG=

Committed: https://crrev.com/d7ef0b8c97d5834f8fdc97bad3e3596e4f84f176
Cr-Commit-Position: refs/heads/master@{#39499}

[jochen (gone - plz use gerrit), 2016-09-16 20:03:09]

The CQ bit was checked by jochen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-16 20:03:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 20:30:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-16 20:30:53]

Dry run: This issue passed the CQ dry run.

[jochen (gone - plz use gerrit), 2016-09-17 18:53:41]

The CQ bit was checked by jochen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-17 18:53:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-17 18:58:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-17 18:58:33]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)

[jochen (gone - plz use gerrit), 2016-09-17 19:34:08]

The CQ bit was checked by jochen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-17 19:34:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-17 19:56:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-17 19:56:28]

Dry run: This issue passed the CQ dry run.

[jochen (gone - plz use gerrit), 2016-09-19 07:22:32]

jochen@chromium.org changed reviewers:
+ vogelheim@chromium.org

[jochen (gone - plz use gerrit), 2016-09-19 07:22:33]

total

Still need to verify that the check works on Windows as well

[jochen (gone - plz use gerrit), 2016-09-19 09:34:25]

The CQ bit was checked by jochen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-19 09:34:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jochen (gone - plz use gerrit), 2016-09-19 09:34:46]

turns out os.path.split() doesn't split into all components just into (path,
file).... now also works on windows

[Michael Achenbach, 2016-09-19 09:35:33]

lgtm - awesome feature!

https://codereview.chromium.org/2346103002/diff/40001/test/cctest/test-slots-...
File test/cctest/test-slots-buffer.cc (left):

https://codereview.chromium.org/2346103002/diff/40001/test/cctest/test-slots-...
test/cctest/test-slots-buffer.cc:1: // Copyright 2015 the V8 project authors.
All rights reserved.
So, the deleted files are truly out-dated? I.e. not needed anymore as tests?

https://codereview.chromium.org/2346103002/diff/40001/tools/verify_source_dep...
File tools/verify_source_deps.py (right):

https://codereview.chromium.org/2346103002/diff/40001/tools/verify_source_dep...
tools/verify_source_deps.py:11: TODO(machenbach): Gyp files in src will point to
source files in src without a
I guess this TODO is somewhat resolved as we now check for tests as well? But we
still approximate, as we might have test and source files with the same name
(after stripping prefixes) that are treated equal by this tool. Maybe change the
TODO?

https://codereview.chromium.org/2346103002/diff/40001/tools/verify_source_dep...
tools/verify_source_deps.py:103: yield
path_no_prefix(os.path.join(*os.path.split(obj)), ALL_GYP_PREFIXES)
Should this not do a obj.split('/') instead of os.path.split (also below) in
order to transform gyp/gn slashes into os.sep?

I'd assume os.path.join(*os.path.split(X)) == X in any case, not?

[commit-bot: I haz the power, 2016-09-19 10:00:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-19 10:00:22]

Dry run: This issue passed the CQ dry run.

[jochen (gone - plz use gerrit), 2016-09-19 10:54:38]

test-slots-buffer.cc was obsoleted by https://codereview.chromium.org/1735523002
js-type-feedback-unittest.cc was obsoleted by
https://codereview.chromium.org/1407913003

https://codereview.chromium.org/2346103002/diff/40001/tools/verify_source_dep...
File tools/verify_source_deps.py (right):

https://codereview.chromium.org/2346103002/diff/40001/tools/verify_source_dep...
tools/verify_source_deps.py:11: TODO(machenbach): Gyp files in src will point to
source files in src without a
On 2016/09/19 at 09:35:33, machenbach (slow) wrote:
> I guess this TODO is somewhat resolved as we now check for tests as well? But
we still approximate, as we might have test and source files with the same name
(after stripping prefixes) that are treated equal by this tool. Maybe change the
TODO?

done

https://codereview.chromium.org/2346103002/diff/40001/tools/verify_source_dep...
tools/verify_source_deps.py:103: yield
path_no_prefix(os.path.join(*os.path.split(obj)), ALL_GYP_PREFIXES)
On 2016/09/19 at 09:35:33, machenbach (slow) wrote:
> Should this not do a obj.split('/') instead of os.path.split (also below) in
order to transform gyp/gn slashes into os.sep?
> 
> I'd assume os.path.join(*os.path.split(X)) == X in any case, not?

I fixed that in the latest patchset.

os.path.split() splits on both / and \, but only on one, not all, so I added a
function pathsplit that splits any OS-style path into its components

[jochen (gone - plz use gerrit), 2016-09-19 10:56:41]

The CQ bit was checked by jochen@chromium.org

[commit-bot: I haz the power, 2016-09-19 10:56:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 10:59:03]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-19 10:59:48]

Description was changed from

==========
Fix BUILD.gn files and add presubmit step

Remove files that were removed from the build files but never deleted.

R=machenbach@chromium.org
BUG=
==========

to

==========
Fix BUILD.gn files and add presubmit step

Remove files that were removed from the build files but never deleted.

R=machenbach@chromium.org
BUG=

Committed: https://crrev.com/d7ef0b8c97d5834f8fdc97bad3e3596e4f84f176
Cr-Commit-Position: refs/heads/master@{#39499}
==========

[commit-bot: I haz the power, 2016-09-19 10:59:49]

Patchset 4 (id:??) landed as
https://crrev.com/d7ef0b8c97d5834f8fdc97bad3e3596e4f84f176
Cr-Commit-Position: refs/heads/master@{#39499}

[Michael Achenbach, 2016-09-19 11:03:33]

https://codereview.chromium.org/2346103002/diff/40001/tools/verify_source_dep...
File tools/verify_source_deps.py (right):

https://codereview.chromium.org/2346103002/diff/40001/tools/verify_source_dep...
tools/verify_source_deps.py:11: TODO(machenbach): Gyp files in src will point to
source files in src without a
On 2016/09/19 10:54:38, jochen wrote:
> On 2016/09/19 at 09:35:33, machenbach (slow) wrote:
> > I guess this TODO is somewhat resolved as we now check for tests as well?
But
> we still approximate, as we might have test and source files with the same
name
> (after stripping prefixes) that are treated equal by this tool. Maybe change
the
> TODO?
> 
> done

forgot to upload?

[Michael Achenbach, 2016-09-19 11:04:39]

On 2016/09/19 11:03:33, machenbach (slow) wrote:
>
https://codereview.chromium.org/2346103002/diff/40001/tools/verify_source_dep...
> File tools/verify_source_deps.py (right):
> 
>
https://codereview.chromium.org/2346103002/diff/40001/tools/verify_source_dep...
> tools/verify_source_deps.py:11: TODO(machenbach): Gyp files in src will point
to
> source files in src without a
> On 2016/09/19 10:54:38, jochen wrote:
> > On 2016/09/19 at 09:35:33, machenbach (slow) wrote:
> > > I guess this TODO is somewhat resolved as we now check for tests as well?
> But
> > we still approximate, as we might have test and source files with the same
> name
> > (after stripping prefixes) that are treated equal by this tool. Maybe change
> the
> > TODO?
> > 
> > done
> 
> forgot to upload?

never mind - saw the CL

[vogelheim, 2016-09-19 11:48:50]

lgtm