Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issue 1407913003: [turbofan] Remove obsolete JSTypeFeedbackSpecializer and JSTypeFeedbackLowering. (Closed)

Created:
5 years, 2 months ago by Benedikt Meurer
Modified:
5 years, 2 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@NamedAccess
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Remove obsolete JSTypeFeedbackSpecializer and JSTypeFeedbackLowering. Both the JSTypeFeedbackSpecializer and the JSTypeFeedbackLowering is dead code by now, since the more general JSNativeContextSpecialization deals with the property/global load/store type feedback in a way that also interacts properly with inlining. BUG=v8:4470 LOG=n R=jarin@chromium.org Committed: https://crrev.com/71bde166b191f6a459827d9be11424405ba13414 Cr-Commit-Position: refs/heads/master@{#31462}

Patch Set 1 #

Patch Set 2 : REBASE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -828 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M src/compiler.h View 2 chunks +0 lines, -7 lines 0 comments Download
M src/compiler.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/compiler/ast-graph-builder.h View 1 5 chunks +6 lines, -11 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 1 24 chunks +33 lines, -84 lines 0 comments Download
D src/compiler/js-type-feedback.h View 1 chunk +0 lines, -114 lines 0 comments Download
D src/compiler/js-type-feedback.cc View 1 chunk +0 lines, -354 lines 0 comments Download
D src/compiler/js-type-feedback-lowering.h View 1 chunk +0 lines, -65 lines 0 comments Download
D src/compiler/js-type-feedback-lowering.cc View 1 chunk +0 lines, -121 lines 0 comments Download
M src/compiler/pipeline.cc View 14 chunks +2 lines, -59 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +0 lines, -1 line 0 comments Download
M test/unittests/unittests.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 24 (13 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1407913003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1407913003/1
5 years, 2 months ago (2015-10-22 06:00:57 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/9202) v8_linux64_rel on ...
5 years, 2 months ago (2015-10-22 06:01:55 UTC) #4
Benedikt Meurer
Hey Jaro, Dead code should be dead! Please take a look. Thanks, Benedikt
5 years, 2 months ago (2015-10-22 08:33:22 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1407913003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1407913003/1
5 years, 2 months ago (2015-10-22 09:12:21 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_win64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel/builds/9880)
5 years, 2 months ago (2015-10-22 09:22:20 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1407913003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1407913003/1
5 years, 2 months ago (2015-10-22 09:23:42 UTC) #12
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/6927) v8_win_rel on ...
5 years, 2 months ago (2015-10-22 09:24:46 UTC) #14
Jarin
lgtm. nice!
5 years, 2 months ago (2015-10-22 09:29:28 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1407913003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1407913003/20001
5 years, 2 months ago (2015-10-22 10:23:28 UTC) #22
Benedikt Meurer
Committed patchset #2 (id:20001) manually as 71bde166b191f6a459827d9be11424405ba13414 (presubmit successful).
5 years, 2 months ago (2015-10-22 10:24:33 UTC) #23
commit-bot: I haz the power
5 years, 2 months ago (2015-10-22 10:24:34 UTC) #24
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/71bde166b191f6a459827d9be11424405ba13414
Cr-Commit-Position: refs/heads/master@{#31462}

Powered by Google App Engine
This is Rietveld 408576698