ninja/mac: Don't write .TOC files into framework bundles.

test/mac/gyptest-framework.py

 #!/usr/bin/env python
 
 # Copyright (c) 2012 Google Inc. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """
 Verifies that app bundles are built correctly.
 """
 
 import TestGyp
 
+import os
 import sys
 
+
+def ls(path):
+  '''Returns a list of all files in a directory, relative to the directory.'''
+  result = []
+  for dirpath, _, files in os.walk(path):
+    for f in files:
+      result.append(os.path.join(dirpath, f)[len(path) + 1:])
+  return result
+
+
 if sys.platform == 'darwin':
   test = TestGyp.TestGyp(formats=['ninja', 'make', 'xcode'])
 
   test.run_gyp('framework.gyp', chdir='framework')
 
   test.build('framework.gyp', 'test_framework', chdir='framework')
 
   # Binary
   test.built_file_must_exist(
       'Test Framework.framework/Versions/A/Test Framework',
@@ skipping 15 matching lines @@
                              chdir='framework')
   test.built_file_must_exist('Test Framework.framework/Resources',
                              chdir='framework')
   test.built_file_must_exist('Test Framework.framework/Test Framework',
                              chdir='framework')
   # PkgInfo.
   test.built_file_must_not_exist(
       'Test Framework.framework/Versions/A/Resources/PkgInfo',
       chdir='framework')
 
+  # Check that no other files get added to the bundle.
+  print set(ls(test.built_file_path('Test Framework.framework',
+                                    chdir='framework')))
+  if set(ls(test.built_file_path('Test Framework.framework',
+                                 chdir='framework'))) != \
+     set(['Versions/A/Test Framework',
+          'Versions/A/Resources/Info.plist',
+          'Versions/A/Resources/English.lproj/InfoPlist.strings',
+          'Test Framework',

[Mark Mentovai, 2013/08/27 21:40:45]

There are no symlinks in here?

[Nico, 2013/08/27 21:42:35]

"Test Framework" is a symlink to the binary (pointing to "Versions/A/Test
Framework"). Versions/Current and Resources are symlinks pointing to
directories, but ls() returns only files not directories, and doesn't traverse
directory symlinks.

[Mark Mentovai, 2013/08/27 21:44:35]

Hmph. I was expecting to see Versions/Current and Resources, but if that’s how
os.walk is gonna be…

[Nico, 2013/08/27 21:45:56]

The existence of the symlinks is checked explicitly below "# Symlinks created by
packaging process" a few lines up. This check here is more to check that nothing
else is in the bundle.

+          'Versions/A/Libraries/empty.c',  # Written by a gyp action.
+          ]):
+    test.fail_test()
+
   test.pass_test()