Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 234603002: Add support for setting TrackStart on solid color layers. (Closed)

Created:
6 years, 8 months ago by aelias_OOO_until_Jul13
Modified:
6 years, 8 months ago
Reviewers:
enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org, darin-cc_chromium.org, tony
Visibility:
Public.

Description

Add support for setting TrackStart on solid color layers. This specifies the space between the edge of the screen and the scrollbar, lengthwise. Blink-side change at https://codereview.chromium.org/234613002 NOTRY=true BUG=361923 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263414

Patch Set 1 #

Patch Set 2 : Fix more unit test compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -34 lines) Patch
M cc/animation/scrollbar_animation_controller_linear_fade_unittest.cc View 1 2 chunks +2 lines, -0 lines 0 comments Download
M cc/animation/scrollbar_animation_controller_thinning_unittest.cc View 1 2 chunks +2 lines, -0 lines 0 comments Download
M cc/layers/scrollbar_layer_unittest.cc View 1 13 chunks +24 lines, -14 lines 0 comments Download
M cc/layers/solid_color_scrollbar_layer.h View 3 chunks +3 lines, -0 lines 0 comments Download
M cc/layers/solid_color_scrollbar_layer.cc View 1 2 chunks +10 lines, -5 lines 0 comments Download
M cc/layers/solid_color_scrollbar_layer_impl.h View 3 chunks +3 lines, -0 lines 0 comments Download
M cc/layers/solid_color_scrollbar_layer_impl.cc View 1 6 chunks +8 lines, -5 lines 0 comments Download
M cc/layers/solid_color_scrollbar_layer_impl_unittest.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M cc/test/layer_test_common.h View 1 1 chunk +18 lines, -0 lines 0 comments Download
M webkit/renderer/compositor_bindings/web_compositor_support_impl.h View 1 1 chunk +8 lines, -1 line 0 comments Download
M webkit/renderer/compositor_bindings/web_compositor_support_impl.cc View 1 1 chunk +16 lines, -4 lines 0 comments Download
M webkit/renderer/compositor_bindings/web_scrollbar_layer_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/renderer/compositor_bindings/web_scrollbar_layer_impl.cc View 1 1 chunk +6 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
aelias_OOO_until_Jul13
PTAL.
6 years, 8 months ago (2014-04-11 04:34:02 UTC) #1
enne (OOO)
lgtm
6 years, 8 months ago (2014-04-11 13:59:01 UTC) #2
aelias_OOO_until_Jul13
The CQ bit was checked by aelias@chromium.org
6 years, 8 months ago (2014-04-11 23:51:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aelias@chromium.org/234603002/20001
6 years, 8 months ago (2014-04-11 23:53:57 UTC) #4
commit-bot: I haz the power
6 years, 8 months ago (2014-04-11 23:56:34 UTC) #5
Message was sent while issue was closed.
Change committed as 263414

Powered by Google App Engine
This is Rietveld 408576698