Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 234613002: Set track_start on solid color layers to the margin. (Closed)

Created:
6 years, 8 months ago by aelias_OOO_until_Jul13
Modified:
6 years, 8 months ago
Reviewers:
tony, abarth-chromium
CC:
blink-reviews, blink-layers+watch_chromium.org, kenneth.christiansen, dglazkov+blink, jamesr, abarth-chromium, enne (OOO)
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Set track_start on solid color layers to the margin. The scrollbar margin on the overlay scrollbar theme is used to distance the thumb from the edge of the screen on all sides, not just the widthwise side. This was already computed properly in the theme's TrackRect, but it wasn't communicated to the WebScrollbarLayer. Also, shrink the margin to 3 DIPs on Android, which on closer inspection better matches the system theme. Chromium-side change at https://codereview.chromium.org/234603002/ NOTRY=true BUG=361923 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171404

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M Source/core/frame/PinchViewport.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/scrolling/ScrollingCoordinator.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/scrolling/ScrollingCoordinator.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/platform/scroll/ScrollbarThemeAndroid.cpp View 1 chunk +1 line, -1 line 0 comments Download
M public/platform/WebCompositorSupport.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
aelias_OOO_until_Jul13
Hi, this is just a small change to better match Android system scrollbar style. tony@ ...
6 years, 8 months ago (2014-04-11 04:35:14 UTC) #1
abarth-chromium
public/ LGTM We don't need to stage the API change?
6 years, 8 months ago (2014-04-11 05:49:30 UTC) #2
aelias_OOO_until_Jul13
We'll need to stage it. It's just on the Chromium side this time that two ...
6 years, 8 months ago (2014-04-11 07:12:37 UTC) #3
tony
LGTM
6 years, 8 months ago (2014-04-11 17:05:54 UTC) #4
aelias_OOO_until_Jul13
The CQ bit was checked by aelias@chromium.org
6 years, 8 months ago (2014-04-13 00:29:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aelias@chromium.org/234613002/1
6 years, 8 months ago (2014-04-13 00:29:21 UTC) #6
commit-bot: I haz the power
6 years, 8 months ago (2014-04-13 00:29:45 UTC) #7
Message was sent while issue was closed.
Change committed as 171404

Powered by Google App Engine
This is Rietveld 408576698