Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(659)

Issue 23460007: don't assume bash is installed (Closed)

Created:
7 years, 3 months ago by qbit
Modified:
5 years, 11 months ago
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

On systems like OpenBSD bash isn't available by default, this removes the hard coded path. BUG= r2025

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (3 generated)
qbit
7 years, 3 months ago (2013-08-28 15:06:28 UTC) #1
qbit
Can anyone gander at this? It's pretty straight forward. At the very least it should ...
7 years, 3 months ago (2013-09-20 13:58:35 UTC) #2
qbit
Not sure if you are the right reviewer for this, but hopefully you can point ...
5 years, 11 months ago (2015-01-19 17:45:33 UTC) #4
Benedikt Meurer
+machenbach, +svenpanne
5 years, 11 months ago (2015-01-19 17:48:44 UTC) #6
Michael Achenbach
PTAL recent gyp authors.
5 years, 11 months ago (2015-01-19 18:06:27 UTC) #8
Nico
lgtm Please mention that bash isn't in /bin on openbsd in the cl description.
5 years, 11 months ago (2015-01-19 18:11:34 UTC) #9
qbit
On 2015/01/19 18:11:34, Nico wrote: > lgtm > > Please mention that bash isn't in ...
5 years, 11 months ago (2015-01-19 19:33:05 UTC) #10
Nico
5 years, 11 months ago (2015-01-20 05:34:43 UTC) #11
Landed in r2025, thanks!

Powered by Google App Engine
This is Rietveld 408576698