Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2174)

Unified Diff: content/test/web_contents_observer_sanity_checker.cc

Issue 2345913002: Fix NetErrorTabHelper with PlzNavigate. (Closed)
Patch Set: fix NavigationHandle::IsErrorPage for reloads of error pages Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/test/web_contents_observer_sanity_checker.cc
diff --git a/content/test/web_contents_observer_sanity_checker.cc b/content/test/web_contents_observer_sanity_checker.cc
index e105985297b0aee72cec381d03542c6fcb485ce2..1d85380fc7827c17a154e04b50c26f26e3e561ce 100644
--- a/content/test/web_contents_observer_sanity_checker.cc
+++ b/content/test/web_contents_observer_sanity_checker.cc
@@ -201,9 +201,6 @@ void WebContentsObserverSanityChecker::DidFinishNavigation(
CHECK(!(navigation_handle->HasCommitted() &&
!navigation_handle->IsErrorPage()) ||
navigation_handle->GetNetErrorCode() == net::OK);
- CHECK(!(navigation_handle->HasCommitted() &&
- navigation_handle->IsErrorPage()) ||
- navigation_handle->GetNetErrorCode() != net::OK);
clamy 2016/09/19 11:46:44 Rather than removing this check, can we expend it
jam 2016/09/19 14:19:40 if you mean navigation_handle->GetURL(), it'll be
clamy 2016/09/19 15:27:11 Acknowledged.
CHECK_EQ(navigation_handle->GetWebContents(), web_contents());
CHECK(!navigation_handle->HasCommitted() ||

Powered by Google App Engine
This is Rietveld 408576698