Fix NetErrorTabHelper with PlzNavigate.

content/test/web_contents_observer_sanity_checker.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/test/web_contents_observer_sanity_checker.h"
 
 #include "base/strings/stringprintf.h"
 #include "build/build_config.h"
 #include "content/browser/frame_host/render_frame_host_impl.h"
 #include "content/common/frame_messages.h"
@@ skipping 183 matching lines @@
   CHECK(navigation_handle->GetRenderFrameHost() != nullptr);
 }
 
 void WebContentsObserverSanityChecker::DidFinishNavigation(
     NavigationHandle* navigation_handle) {
   CHECK(NavigationIsOngoing(navigation_handle));
 
   CHECK(!(navigation_handle->HasCommitted() &&
           !navigation_handle->IsErrorPage()) ||
         navigation_handle->GetNetErrorCode() == net::OK);
-  CHECK(!(navigation_handle->HasCommitted() &&
-          navigation_handle->IsErrorPage()) ||
-        navigation_handle->GetNetErrorCode() != net::OK);

[clamy, 2016/09/19 11:46:44]

Rather than removing this check, can we expend it to cover
navigation_handle->GetNetErrorCode() != net::OK || rul = kUnreachableUrl? I
think these are the only two cases where we can have an error page.

[jam, 2016/09/19 14:19:40]

if you mean navigation_handle->GetURL(), it'll be the URL of the page the user
navigated to, and not the error page. base_url isn't exposed at this point.

[clamy, 2016/09/19 15:27:11]

Acknowledged.

   CHECK_EQ(navigation_handle->GetWebContents(), web_contents());
 
   CHECK(!navigation_handle->HasCommitted() ||
         navigation_handle->GetRenderFrameHost() != nullptr);
 
   ongoing_navigations_.erase(navigation_handle);
 }
 
 void WebContentsObserverSanityChecker::DidStartProvisionalLoadForFrame(
     RenderFrameHost* render_frame_host,
@@ skipping 191 matching lines @@
       if (live_routes_.count(entry.first))
         return true;
       if (current_hosts_.count(entry.first))
         return true;
     }
   }
   return false;
 }
 
 }  // namespace content