Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Issue 2345883002: Run the ninja "up-to-date" check for all compiles, but just as an fyi (Closed)

Created:
4 years, 3 months ago by agrieve
Modified:
4 years, 3 months ago
Reviewers:
Dirk Pranke, Nico
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Run the ninja "up-to-date" check for all compiles, but just as an fyi This will allow me (and others) to figure out when it's safe to enable ensure_up_to_date. BUG=646165 Committed: https://chromium.googlesource.com/chromium/tools/build/+/b6d326d6f6f9608bba307109cc4a1c5efc5946bb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M scripts/slave/compile.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
agrieve
On 2016/09/16 00:36:45, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:dpranke@chromium.org Not sure why ...
4 years, 3 months ago (2016-09-16 00:37:00 UTC) #3
Dirk Pranke
+thakis for FYI. lgtm.
4 years, 3 months ago (2016-09-16 00:42:00 UTC) #5
Nico
On 2016/09/16 00:42:00, Dirk Pranke wrote: > +thakis for FYI. > > lgtm. Nice!
4 years, 3 months ago (2016-09-16 00:48:29 UTC) #6
agrieve
On 2016/09/16 00:48:29, Nico wrote: > On 2016/09/16 00:42:00, Dirk Pranke wrote: > > +thakis ...
4 years, 3 months ago (2016-09-16 00:55:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2345883002/1
4 years, 3 months ago (2016-09-16 00:56:08 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 01:00:43 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/b6d326d6f6f9608bba30...

Powered by Google App Engine
This is Rietveld 408576698