Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Unified Diff: scripts/slave/compile.py

Issue 2345883002: Run the ninja "up-to-date" check for all compiles, but just as an fyi (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/compile.py
diff --git a/scripts/slave/compile.py b/scripts/slave/compile.py
index 2fde4d01acc028cfc780f2dbb82557c667dac725..44f7e0e422968573a3ea70139c6b5bce894c542c 100755
--- a/scripts/slave/compile.py
+++ b/scripts/slave/compile.py
@@ -428,13 +428,13 @@ def main_ninja(options, args, env):
# Run the build.
env.print_overrides()
exit_status = chromium_utils.RunCommand(command, env=env)
- if exit_status == 0 and options.ninja_ensure_up_to_date:
+ if exit_status == 0:
# Run the build again if we want to check that the no-op build is clean.
filter_obj = EnsureUpToDateFilter()
# Append `-d explain` to help diagnose in the failure case.
command += ['-d', 'explain', '-n']
chromium_utils.RunCommand(command, env=env, filter_obj=filter_obj)
- if not filter_obj.was_up_to_date:
+ if not filter_obj.was_up_to_date and options.ninja_ensure_up_to_date:
print 'Failing build because ninja reported work to do.'
print 'This means that after completing a compile, another was run and'
print 'it resulted in still having work to do (that is, a no-op build'
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698