[Sync] Merge //components/browser_sync into one directory.

[Sync] Merge //components/browser_sync into one directory.

These were originally split due to a weird usage by cloud_print, which
is no longer part of chromium.

- Moved all of ./browser and ./common into .
- Ran //tools/git/mass-rename.py
- Merged the build targets
- Ran git cl format
- Fixed lint errors in //components/browser_sync

BUG=646955
TBR=cpu

Committed: https://crrev.com/26f4022d5f47db6a1123915de511e2339b70e2a2
Cr-Commit-Position: refs/heads/master@{#419268}

[maxbogue, 2016-09-16 00:49:56]

The CQ bit was checked by maxbogue@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-16 00:50:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 01:05:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-16 01:05:38]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)

[maxbogue, 2016-09-16 01:17:58]

maxbogue@chromium.org changed reviewers:
+ skym@chromium.org

[maxbogue, 2016-09-16 01:18:00]

Sky, PTAL! It looks like a lot of files but really most of the changes are
automated formatter changes inside the component.

[skym, 2016-09-16 18:33:09]

lgtm

https://codereview.chromium.org/2345843003/diff/1/components/browser_sync/pro...
File components/browser_sync/profile_sync_service.cc (right):

https://codereview.chromium.org/2345843003/diff/1/components/browser_sync/pro...
components/browser_sync/profile_sync_service.cc:1878: } break;
Whaaaat? This is bizarre, and why is cl format putting these on the same line.
Can you remove the { } from here? I don't think they do anything functional, and
they (imo) obscure if this break is run or not.

[maxbogue, 2016-09-16 19:12:49]

Description was changed from

==========
[Sync] Merge //components/browser_sync into one directory.

These were originally split due to a weird usage by cloud_print, which
is no longer part of chromium.

- Moved all of ./browser and ./common into .
- Ran //tools/git/mass-rename.py
- Merged the build targets
- Ran git cl format
- Fixed lint errors in //components/browser_sync

BUG=646955
==========

to

==========
[Sync] Merge //components/browser_sync into one directory.

These were originally split due to a weird usage by cloud_print, which
is no longer part of chromium.

- Moved all of ./browser and ./common into .
- Ran //tools/git/mass-rename.py
- Merged the build targets
- Ran git cl format
- Fixed lint errors in //components/browser_sync

BUG=646955
TBR=cpu
==========

[maxbogue, 2016-09-16 19:13:26]

maxbogue@chromium.org changed reviewers:
+ cpu@chromium.org

[maxbogue, 2016-09-16 19:13:28]

TBR'ing cpu@ for all the things since this is just refactoring.

https://codereview.chromium.org/2345843003/diff/1/components/browser_sync/pro...
File components/browser_sync/profile_sync_service.cc (right):

https://codereview.chromium.org/2345843003/diff/1/components/browser_sync/pro...
components/browser_sync/profile_sync_service.cc:1878: } break;
On 2016/09/16 18:33:09, skym wrote:
> Whaaaat? This is bizarre, and why is cl format putting these on the same line.
> Can you remove the { } from here? I don't think they do anything functional,
and
> they (imo) obscure if this break is run or not.

I've removed the braces and just done the error text construction inline.

[maxbogue, 2016-09-16 19:16:14]

The CQ bit was checked by maxbogue@chromium.org

[maxbogue, 2016-09-16 19:16:15]

The patchset sent to the CQ was uploaded after l-g-t-m from skym@chromium.org
Link to the patchset: https://codereview.chromium.org/2345843003/#ps20001
(title: "Address comment + rebase.")

[commit-bot: I haz the power, 2016-09-16 19:16:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 20:22:39]

Description was changed from

==========
[Sync] Merge //components/browser_sync into one directory.

These were originally split due to a weird usage by cloud_print, which
is no longer part of chromium.

- Moved all of ./browser and ./common into .
- Ran //tools/git/mass-rename.py
- Merged the build targets
- Ran git cl format
- Fixed lint errors in //components/browser_sync

BUG=646955
TBR=cpu
==========

to

==========
[Sync] Merge //components/browser_sync into one directory.

These were originally split due to a weird usage by cloud_print, which
is no longer part of chromium.

- Moved all of ./browser and ./common into .
- Ran //tools/git/mass-rename.py
- Merged the build targets
- Ran git cl format
- Fixed lint errors in //components/browser_sync

BUG=646955
TBR=cpu
==========

[commit-bot: I haz the power, 2016-09-16 20:22:42]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-16 20:25:44]

Description was changed from

==========
[Sync] Merge //components/browser_sync into one directory.

These were originally split due to a weird usage by cloud_print, which
is no longer part of chromium.

- Moved all of ./browser and ./common into .
- Ran //tools/git/mass-rename.py
- Merged the build targets
- Ran git cl format
- Fixed lint errors in //components/browser_sync

BUG=646955
TBR=cpu
==========

to

==========
[Sync] Merge //components/browser_sync into one directory.

These were originally split due to a weird usage by cloud_print, which
is no longer part of chromium.

- Moved all of ./browser and ./common into .
- Ran //tools/git/mass-rename.py
- Merged the build targets
- Ran git cl format
- Fixed lint errors in //components/browser_sync

BUG=646955
TBR=cpu

Committed: https://crrev.com/26f4022d5f47db6a1123915de511e2339b70e2a2
Cr-Commit-Position: refs/heads/master@{#419268}
==========

[commit-bot: I haz the power, 2016-09-16 20:25:46]

Patchset 2 (id:??) landed as
https://crrev.com/26f4022d5f47db6a1123915de511e2339b70e2a2
Cr-Commit-Position: refs/heads/master@{#419268}