[modules] Turn JSModule into Module.

[modules] Turn JSModule into Module.

Rename JSModule to Module and make it a Struct rather than a JSObject.  We will
later add a separate JSModuleNamespace object to implement the 'import * as foo'
syntax.

BUG=v8:1569
Committed: https://crrev.com/7c05d8a4a6336b9cee984a765504531b80590fc7
Cr-Commit-Position: refs/heads/master@{#39477}

[neis, 2016-09-15 21:12:24]

Description was changed from

==========
[modules] Turn JSModule into Module.

Rename JSModule to Module and make it a struct rather than a JSObject.  We will
later add a separate JSModuleNamespace object to implement the 'import * as foo'
syntax.

BUG=
==========

to

==========
[modules] Turn JSModule into Module.

Rename JSModule to Module and make it a Struct rather than a JSObject.  We will
later add a separate JSModuleNamespace object to implement the 'import * as foo'
syntax.

BUG=v8:1569
==========

[neis, 2016-09-15 21:12:24]

neis@chromium.org changed reviewers:
+ adamk@chromium.org

[neis, 2016-09-15 21:12:46]

The CQ bit was checked by neis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 21:12:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[neis, 2016-09-15 21:22:38]

ptal

[adamk, 2016-09-15 21:44:03]

lgtm % nits (which I now realize are pre-existing, so you could even leave them
for a later cleanup :)

https://codereview.chromium.org/2345823002/diff/20001/src/api.cc
File src/api.cc (right):

https://codereview.chromium.org/2345823002/diff/20001/src/api.cc#newcode2010
src/api.cc:2010:
i::Handle<i::SharedFunctionInfo>::cast(Utils::OpenHandle(*generic));
You shouldn't need this ::cast(), OpenHandle is supposed to know that
UnboundScript is a SharedFunctionInfo (from my reading of src/api.h).

https://codereview.chromium.org/2345823002/diff/20001/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/2345823002/diff/20001/src/objects.cc#newcode1...
src/objects.cc:19472: Handle<ObjectHashTable> exports(module->exports());
Nit: pass an Isolate* to the Handle constructor, here and below.

[neis, 2016-09-15 23:22:58]

https://codereview.chromium.org/2345823002/diff/20001/src/api.cc
File src/api.cc (right):

https://codereview.chromium.org/2345823002/diff/20001/src/api.cc#newcode2010
src/api.cc:2010:
i::Handle<i::SharedFunctionInfo>::cast(Utils::OpenHandle(*generic));
On 2016/09/15 21:44:02, adamk wrote:
> You shouldn't need this ::cast(), OpenHandle is supposed to know that
> UnboundScript is a SharedFunctionInfo (from my reading of src/api.h).

Done.

https://codereview.chromium.org/2345823002/diff/20001/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/2345823002/diff/20001/src/objects.cc#newcode1...
src/objects.cc:19472: Handle<ObjectHashTable> exports(module->exports());
On 2016/09/15 21:44:02, adamk wrote:
> Nit: pass an Isolate* to the Handle constructor, here and below.

Done.

[neis, 2016-09-15 23:24:36]

neis@chromium.org changed reviewers:
+ bmeurer@chromium.org, ulan@chromium.org

[neis, 2016-09-15 23:25:24]

+ulan,+bmeurer for heap and compiler. thanks!

[Benedikt Meurer, 2016-09-16 03:07:42]

LGTM

[ulan, 2016-09-16 09:47:06]

heap lgtm

[neis, 2016-09-16 16:11:11]

The CQ bit was checked by neis@chromium.org

[neis, 2016-09-16 16:11:12]

The patchset sent to the CQ was uploaded after l-g-t-m from adamk@chromium.org
Link to the patchset: https://codereview.chromium.org/2345823002/#ps40001
(title: "Address comments.")

[commit-bot: I haz the power, 2016-09-16 16:11:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 16:47:14]

Description was changed from

==========
[modules] Turn JSModule into Module.

Rename JSModule to Module and make it a Struct rather than a JSObject.  We will
later add a separate JSModuleNamespace object to implement the 'import * as foo'
syntax.

BUG=v8:1569
==========

to

==========
[modules] Turn JSModule into Module.

Rename JSModule to Module and make it a Struct rather than a JSObject.  We will
later add a separate JSModuleNamespace object to implement the 'import * as foo'
syntax.

BUG=v8:1569
==========

[commit-bot: I haz the power, 2016-09-16 16:47:15]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-16 16:48:05]

Description was changed from

==========
[modules] Turn JSModule into Module.

Rename JSModule to Module and make it a Struct rather than a JSObject.  We will
later add a separate JSModuleNamespace object to implement the 'import * as foo'
syntax.

BUG=v8:1569
==========

to

==========
[modules] Turn JSModule into Module.

Rename JSModule to Module and make it a Struct rather than a JSObject.  We will
later add a separate JSModuleNamespace object to implement the 'import * as foo'
syntax.

BUG=v8:1569

Committed: https://crrev.com/7c05d8a4a6336b9cee984a765504531b80590fc7
Cr-Commit-Position: refs/heads/master@{#39477}
==========

[commit-bot: I haz the power, 2016-09-16 16:48:06]

Patchset 3 (id:??) landed as
https://crrev.com/7c05d8a4a6336b9cee984a765504531b80590fc7
Cr-Commit-Position: refs/heads/master@{#39477}