Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1573)

Unified Diff: src/objects-debug.cc

Issue 2345823002: [modules] Turn JSModule into Module. (Closed)
Patch Set: Address comments. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/objects-body-descriptors-inl.h ('k') | src/objects-inl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects-debug.cc
diff --git a/src/objects-debug.cc b/src/objects-debug.cc
index b860e73d150b9ce06c62b7baf54f5936d5cb341c..e014038933a659d9f0e420521aa11e02a45dc408 100644
--- a/src/objects-debug.cc
+++ b/src/objects-debug.cc
@@ -166,9 +166,6 @@ void HeapObject::HeapObjectVerify() {
case JS_PROXY_TYPE:
JSProxy::cast(this)->JSProxyVerify();
break;
- case JS_MODULE_TYPE:
- JSModule::cast(this)->JSModuleVerify();
- break;
case FOREIGN_TYPE:
Foreign::cast(this)->ForeignVerify();
break;
@@ -834,8 +831,6 @@ void JSRegExp::JSRegExpVerify() {
}
}
-void JSModule::JSModuleVerify() { CHECK(IsJSModule()); }
-
void JSProxy::JSProxyVerify() {
CHECK(IsJSProxy());
VerifyPointer(target());
@@ -904,6 +899,11 @@ void Box::BoxVerify() {
value()->ObjectVerify();
}
+void Module::ModuleVerify() {
+ CHECK(IsModule());
+ exports()->ObjectVerify();
+ // TODO(neis): Check more.
+}
void PrototypeInfo::PrototypeInfoVerify() {
CHECK(IsPrototypeInfo());
« no previous file with comments | « src/objects-body-descriptors-inl.h ('k') | src/objects-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698