Issue 23458029: Make both DevToolsServer constructors to be equivalent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23458029: Make both DevToolsServer constructors to be equivalent (Closed)

Created:
7 years, 3 months ago by mnaganov (inactive)

Modified:
7 years, 3 months ago

Reviewers:
bulach

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Make both DevToolsServer constructors to be equivalent We are moving away from using the prefixless constructor in Chrome for Android code. We need to make sure that both versions of the constructor respect kRemoteDebuggingSocketName flag. BUG=263735 R=bulach@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222163

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -0 lines)			Patch
	M	chrome/browser/android/dev_tools_server.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	chrome/browser/android/dev_tools_server.cc	View		1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

mnaganov (inactive)

This is in accordance with the changes in Chrome for Android code.

7 years, 3 months ago (2013-09-06 20:57:34 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mnaganov@chromium.org/23458029/1

7 years, 3 months ago (2013-09-09 14:39:16 UTC) #3

commit-bot: I haz the power

Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=76850

7 years, 3 months ago (2013-09-10 00:14:04 UTC) #4

mnaganov (inactive)

7 years, 3 months ago (2013-09-10 00:57:01 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as r222163 (presubmit successful).

Expand Messages | Collapse Messages