Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Side by Side Diff: chrome/browser/android/dev_tools_server.h

Issue 23458029: Make both DevToolsServer constructors to be equivalent (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/android/dev_tools_server.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_ANDROID_DEV_TOOLS_SERVER_H_ 5 #ifndef CHROME_BROWSER_ANDROID_DEV_TOOLS_SERVER_H_
6 #define CHROME_BROWSER_ANDROID_DEV_TOOLS_SERVER_H_ 6 #define CHROME_BROWSER_ANDROID_DEV_TOOLS_SERVER_H_
7 7
8 #include <string> 8 #include <string>
9 #include <jni.h> 9 #include <jni.h>
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
11 11
12 namespace content { 12 namespace content {
13 class DevToolsHttpHandler; 13 class DevToolsHttpHandler;
14 } 14 }
15 15
16 // This class controls Developer Tools remote debugging server. 16 // This class controls Developer Tools remote debugging server.
17 class DevToolsServer { 17 class DevToolsServer {
18 public: 18 public:
19 // TODO(mnaganov): Remove the prefixless constructor after having its
20 // usage removed in the Chrome for Android code.
19 DevToolsServer(); 21 DevToolsServer();
20 explicit DevToolsServer(const std::string& socket_name_prefix); 22 explicit DevToolsServer(const std::string& socket_name_prefix);
21 ~DevToolsServer(); 23 ~DevToolsServer();
22 24
23 // Opens linux abstract socket to be ready for remote debugging. 25 // Opens linux abstract socket to be ready for remote debugging.
24 void Start(); 26 void Start();
25 27
26 // Closes debugging socket, stops debugging. 28 // Closes debugging socket, stops debugging.
27 void Stop(); 29 void Stop();
28 30
29 bool IsStarted() const; 31 bool IsStarted() const;
30 32
31 private: 33 private:
32 std::string socket_name_; 34 std::string socket_name_;
33 content::DevToolsHttpHandler* protocol_handler_; 35 content::DevToolsHttpHandler* protocol_handler_;
34 36
35 DISALLOW_COPY_AND_ASSIGN(DevToolsServer); 37 DISALLOW_COPY_AND_ASSIGN(DevToolsServer);
36 }; 38 };
37 39
38 bool RegisterDevToolsServer(JNIEnv* env); 40 bool RegisterDevToolsServer(JNIEnv* env);
39 41
40 #endif // CHROME_BROWSER_ANDROID_DEV_TOOLS_SERVER_H_ 42 #endif // CHROME_BROWSER_ANDROID_DEV_TOOLS_SERVER_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/android/dev_tools_server.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698