Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 23458028: Revert 221035 "Revert 219146 "[sync] Force re-auth during sync s..." (Closed)

Created:
7 years, 3 months ago by sail
Modified:
7 years, 3 months ago
Reviewers:
Raghu Simha, sail
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 221035 "Revert 219146 "[sync] Force re-auth during sync s..." Restoring the change. Verified that this was not the cause of bug 278543. > Revert 219146 "[sync] Force re-auth during sync setup if Oauth2 ..." > > > [sync] Force re-auth during sync setup if Oauth2 token is unavailable > > > > If an enterprise user disables sync via a dashboard clear, and goes on > > to re-enable sync at a later time, set up can fail due to an expired or > > missing Oauth2 token. > > > > This patch updates SyncSetupHandler::OpenSyncSetup to first check if an > > auth token is available for sync, and if not, force a re-auth. > > > > R=atwilson > > TBR=fgorski,rogerta > > BUG=276650 > > TEST=Disable sync for an enterprise user, exit chrome, delete "Web > > Data*" from the profile dir, restart chrome, and set up sync. Re-auth > > must be forced in this case. > > > > Review URL: https://chromiumcodereview.appspot.com/23005016 > > TBR=rsimha@chromium.org > > Review URL: https://codereview.chromium.org/23759003 TBR=sail@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221740

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -3 lines) Patch
M trunk/src/chrome/browser/signin/profile_oauth2_token_service.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M trunk/src/chrome/browser/ui/sync/one_click_signin_helper.cc View 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
sail
7 years, 3 months ago (2013-09-06 18:30:38 UTC) #1
sail
Committed patchset #1 manually as r221740.
7 years, 3 months ago (2013-09-06 18:30:51 UTC) #2
Raghu Simha
7 years, 3 months ago (2013-09-06 22:31:30 UTC) #3
Message was sent while issue was closed.
LGTM. Thanks for the re-revert.

Powered by Google App Engine
This is Rietveld 408576698