Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Issue 23759003: Revert 219146 "[sync] Force re-auth during sync setup if Oauth2 ..." (Closed)

Created:
7 years, 3 months ago by sail
Modified:
7 years, 3 months ago
Reviewers:
Raghu Simha
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 219146 "[sync] Force re-auth during sync setup if Oauth2 ..." > [sync] Force re-auth during sync setup if Oauth2 token is unavailable > > If an enterprise user disables sync via a dashboard clear, and goes on > to re-enable sync at a later time, set up can fail due to an expired or > missing Oauth2 token. > > This patch updates SyncSetupHandler::OpenSyncSetup to first check if an > auth token is available for sync, and if not, force a re-auth. > > R=atwilson > TBR=fgorski,rogerta > BUG=276650 > TEST=Disable sync for an enterprise user, exit chrome, delete "Web > Data*" from the profile dir, restart chrome, and set up sync. Re-auth > must be forced in this case. > > Review URL: https://chromiumcodereview.appspot.com/23005016 TBR=rsimha@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221035

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -15 lines) Patch
M trunk/src/chrome/browser/signin/profile_oauth2_token_service.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M trunk/src/chrome/browser/ui/sync/one_click_signin_helper.cc View 1 chunk +3 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
sail
7 years, 3 months ago (2013-09-03 21:55:42 UTC) #1
sail
Committed patchset #1 manually as r221035.
7 years, 3 months ago (2013-09-03 21:55:58 UTC) #2
Raghu Simha
7 years, 3 months ago (2013-09-03 22:17:45 UTC) #3
Message was sent while issue was closed.
LGTM based on comments in bug 278543.

Powered by Google App Engine
This is Rietveld 408576698