Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(637)

Issue 2345693005: Prune createVisiblePositionDeprecated from unit tests (Closed)

Created:
4 years, 3 months ago by Xiaocheng
Modified:
4 years, 3 months ago
Reviewers:
tkent, yosin_UTC9
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, kinuko+watch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prune createVisiblePositionDeprecated from unit tests BUG=647219 Committed: https://crrev.com/325c64a962cb5c007368ef431dfa863c26c7847b Cr-Commit-Position: refs/heads/master@{#419135}

Patch Set 1 #

Messages

Total messages: 12 (7 generated)
Xiaocheng
PTAL.
4 years, 3 months ago (2016-09-16 08:33:09 UTC) #4
tkent
lgtm
4 years, 3 months ago (2016-09-16 08:46:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2345693005/1
4 years, 3 months ago (2016-09-16 09:14:57 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-16 09:19:46 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 09:21:34 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/325c64a962cb5c007368ef431dfa863c26c7847b
Cr-Commit-Position: refs/heads/master@{#419135}

Powered by Google App Engine
This is Rietveld 408576698