third_party/WebKit/Source/core/html/HTMLTextFormControlElementTest.cpp - Issue 2345693005: Prune createVisiblePositionDeprecated from unit tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLTextFormControlElementTest.cpp

Issue 2345693005: Prune createVisiblePositionDeprecated from unit tests (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/VisibleUnitsTest.cpp ('k') | third_party/WebKit/Source/web/tests/WebFrameTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLTextFormControlElementTest.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLTextFormControlElementTest.cpp b/third_party/WebKit/Source/core/html/HTMLTextFormControlElementTest.cpp

index 8d6255521c64ac2adda8da8a2d8f0e10b9ad1322..ad2059b0d5a639707a2aad2476c73ee5409720a1 100644

--- a/third_party/WebKit/Source/core/html/HTMLTextFormControlElementTest.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLTextFormControlElementTest.cpp

@@ -129,9 +129,9 @@ typedef VisiblePosition(*VisblePositionFunction)(const VisiblePosition&);

void testFunctionEquivalence(const Position& position, PositionFunction positionFunction, VisblePositionFunction visibleFunction)

{

- VisiblePosition visiblePosition = createVisiblePositionDeprecated(position);

+ VisiblePosition visiblePosition = createVisiblePosition(position);

VisiblePosition expected = visibleFunction(visiblePosition);

- VisiblePosition actual = createVisiblePositionDeprecated(positionFunction(position));

+ VisiblePosition actual = createVisiblePosition(positionFunction(position));

EXPECT_EQ(expected.deepEquivalent(), actual.deepEquivalent());

}

@@ -147,6 +147,7 @@ static VisiblePosition endOfWord(const VisiblePosition& position)

void testBoundary(Document& document, HTMLTextFormControlElement& textControl)

{

+ document.updateStyleAndLayout();

for (unsigned i = 0; i < textControl.innerEditorValue().length(); i++) {

textControl.setSelectionRange(i, i);

Position position = document.frame()->selection().start();