Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 2345653002: Simplify build/common.gypi shell used to keep closure compilation going (Closed)

Created:
4 years, 3 months ago by Dan Beam
Modified:
4 years, 3 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify build/common.gypi shell used to keep closure compilation going R=dpranke@chromium.org BUG=646969

Patch Set 1 #

Patch Set 2 : variables -> target_defaults #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6326 lines) Patch
M build/common.gypi View 1 1 chunk +2 lines, -6326 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 2 (1 generated)
Dirk Pranke
4 years, 3 months ago (2016-09-22 23:09:21 UTC) #2
Message was sent while issue was closed.
closing, since my CL landed and seems to have stuck.

Powered by Google App Engine
This is Rietveld 408576698