Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(709)

Issue 2345503005: Re-add common.gypi to help fix closure_compilation. (Closed)

Created:
4 years, 3 months ago by Dan Beam
Modified:
4 years, 3 months ago
Reviewers:
Dirk Pranke, dpranke, brettw
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-add common.gypi to help fix closure_compilation. This is a temporary fix until Dirk can change the closure_compilation uses of gyp_chromium correctly. Stolen from Dirk Pranke <dpranke@chromium.org>; and stripped of 'includes': https://codereview.chromium.org/2331423005/ TBR=brettw@chromium.org, dpranke@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation BUG=646969 Committed: https://crrev.com/0109afc37c2d185d9825e4a93809e4acab435a23 Cr-Commit-Position: refs/heads/master@{#418779}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6339 lines, -0 lines) Patch
A build/common.gypi View 1 chunk +6336 lines, -0 lines 0 comments Download
M build/gyp_chromium.py View 1 chunk +3 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (7 generated)
Dan Beam
4 years, 3 months ago (2016-09-15 02:58:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2345503005/1
4 years, 3 months ago (2016-09-15 02:59:32 UTC) #6
dpranke
lgtm, thanks for picking it up.
4 years, 3 months ago (2016-09-15 03:32:13 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-15 04:26:00 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 04:28:10 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0109afc37c2d185d9825e4a93809e4acab435a23
Cr-Commit-Position: refs/heads/master@{#418779}

Powered by Google App Engine
This is Rietveld 408576698