| Index: native_client_sdk/src/tests/nacl_io_test/socket_test.cc
|
| diff --git a/native_client_sdk/src/tests/nacl_io_test/socket_test.cc b/native_client_sdk/src/tests/nacl_io_test/socket_test.cc
|
| index 90c59dd99c80ea7c94db1577a4d365fb18a3b854..808a7ed99d78af13fcaec9f163662c7c50d1e624 100644
|
| --- a/native_client_sdk/src/tests/nacl_io_test/socket_test.cc
|
| +++ b/native_client_sdk/src/tests/nacl_io_test/socket_test.cc
|
| @@ -221,11 +221,16 @@ TEST_F(SocketTest, Setsockopt) {
|
| socklen_t len = 10;
|
| char optval[len];
|
|
|
| - EXPECT_LT(ki_setsockopt(123, SOL_SOCKET, SO_ACCEPTCONN, NULL, len), 0);
|
| + // Passing a bad address as optval should generate EFAULT
|
| + EXPECT_EQ(-1, ki_setsockopt(123, SOL_SOCKET, SO_ACCEPTCONN, NULL, len));
|
| EXPECT_EQ(errno, EFAULT);
|
| - EXPECT_LT(ki_setsockopt(-1, SOL_SOCKET, SO_ACCEPTCONN, optval, len), 0);
|
| +
|
| + // Passing a bad socket descriptor should generate EBADF
|
| + EXPECT_EQ(-1, ki_setsockopt(-1, SOL_SOCKET, SO_ACCEPTCONN, optval, len));
|
| EXPECT_EQ(errno, EBADF);
|
| - EXPECT_LT(ki_setsockopt(0, SOL_SOCKET, SO_ACCEPTCONN, optval, len), 0);
|
| +
|
| + // Passing an FD that is valid but not a socket should generate ENOTSOCK
|
| + EXPECT_EQ(-1, ki_setsockopt(0, SOL_SOCKET, SO_ACCEPTCONN, optval, len));
|
| EXPECT_EQ(errno, ENOTSOCK);
|
| }
|
|
|
|
|