[NaCl SDK] nacl_io: Add initial support for getsockopt

native_client_sdk/src/tests/nacl_io_test/socket_test.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <arpa/inet.h>
 #include <errno.h>
 #include <fcntl.h>
 #include <netinet/in.h>
 #include <pthread.h>
 #include <sys/types.h>
@@ skipping 203 matching lines @@
   EXPECT_LT(ki_sendmsg(-1, &msg, 0), 0);
   EXPECT_EQ(errno, EBADF);
   EXPECT_LT(ki_sendmsg(0, &msg, 0), 0);
   EXPECT_EQ(errno, ENOTSOCK);
 }
 
 TEST_F(SocketTest, Setsockopt) {
   socklen_t len = 10;
   char optval[len];
 
-  EXPECT_LT(ki_setsockopt(123, SOL_SOCKET, SO_ACCEPTCONN, NULL, len), 0);
+  // Passing a bad address as optval should generate EFAULT
+  EXPECT_EQ(-1, ki_setsockopt(123, SOL_SOCKET, SO_ACCEPTCONN, NULL, len));
   EXPECT_EQ(errno, EFAULT);
-  EXPECT_LT(ki_setsockopt(-1, SOL_SOCKET, SO_ACCEPTCONN, optval, len), 0);
+
+  // Passing a bad socket descriptor should generate EBADF
+  EXPECT_EQ(-1, ki_setsockopt(-1, SOL_SOCKET, SO_ACCEPTCONN, optval, len));
   EXPECT_EQ(errno, EBADF);
-  EXPECT_LT(ki_setsockopt(0, SOL_SOCKET, SO_ACCEPTCONN, optval, len), 0);
+
+  // Passing an FD that is valid but not a socket should generate ENOTSOCK
+  EXPECT_EQ(-1, ki_setsockopt(0, SOL_SOCKET, SO_ACCEPTCONN, optval, len));
   EXPECT_EQ(errno, ENOTSOCK);
 }
 
 TEST_F(SocketTest, Shutdown) {
   EXPECT_LT(ki_shutdown(-1, SHUT_RDWR), 0);
   EXPECT_EQ(errno, EBADF);
   EXPECT_LT(ki_shutdown(0, SHUT_RDWR), 0);
   EXPECT_EQ(errno, ENOTSOCK);
 }
 
@@ skipping 162 matching lines @@
 TEST(SocketUtilityFunctions, Ntohl) {
   uint8_t network_bytes[4] = { 0x44, 0x33, 0x22, 0x11 };
   uint32_t network_long;
   memcpy(&network_long, network_bytes, 4);
   uint32_t host_long = ntohl(network_long);
   EXPECT_EQ(host_long, 0x44332211);
 }
 
 #endif  // !defined(__GLIBC__)
 #endif  // PROVIDES_SOCKETPAIR_API